Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret flags in DS4 Output Reports #54

Closed
Kanuan opened this issue Apr 8, 2021 · 0 comments
Closed

Interpret flags in DS4 Output Reports #54

Kanuan opened this issue Apr 8, 2021 · 0 comments
Assignees
Labels
bug Something isn't working Core Core/Common Driver Topic

Comments

@Kanuan
Copy link
Collaborator

Kanuan commented Apr 8, 2021

In DS4 mode in conjunction with DS4Windows, Output Reports protocol 0x11 are sent to the driver containing Light Bar information and Rumble commands. These info are always interpreted by the driver, setting the received rumble values and translating the Light Bar color to LEDs.

In the packets there are flags indicating if the rumble/light bar color values should actually be interpreted, as shown in the image below:

image
source: psdevwiki DS4-BT

If they are not verified, there is a chance that the values are actually random/garbage data and the driver interpretes them anyway. Although DS4Windows seems to be always sending the correct values regardless of the flags, it should be better if DsHidMini were to mimic the real DS4 behavior on this.

Because there is a flag regarding "Flash", which seems to be related to the "Flash bright" and "Flash dark" bytes, this flag can be potentially useful to ignore Flash/Pulse commands or to translating them to another LED state.

@Kanuan Kanuan changed the title Interpret flags of Output Report received in DS4 mode Interpret flags in DS4 Output Reports Apr 8, 2021
@nefarius nefarius added bug Something isn't working Core Core/Common Driver Topic labels Apr 8, 2021
@nefarius nefarius self-assigned this Apr 8, 2021
@nefarius nefarius added this to the Fixed in v1.4.x milestone Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Core/Common Driver Topic
Projects
None yet
Development

No branches or pull requests

2 participants