-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed python_requires="<4" #1021
Conversation
Python 4 doesn't exist, this requirement is redundant
From the discussion in #1020:
|
Thank you Ned. I changed the default from the caret because I don't want to break things for other people (like myself, in other projects) that haven't always specified their Python version as "<4.0". They will also get a failure on install, not just from poetry, but from pip itself. see comment here from @henryiii
I am already running into this issue with my own set of tools that depend on each other, and now I have the same issue trying to install Beyond avoiding that issue, I don't understand the need to specify Python "<4.0" if there's no concrete plans for 4.0, and Python follows CalVer instead of SemVer. from this discussion where @matthewfeickert asks
Happy to hear that I'm wrong but this is my current understanding. |
People may already be aware of this, so apologies if I'm reposting or missing the context if I had read more of the links in this Issue, but @NickleDave is currently having some real world problems with other libraries specifying |
I still think poetry is doing the wrong thing. But 4.0 is a long way off, and this can relieve some pain. If 4.0 does emerge, and needs to be excluded, we will all as a community have to revisit how these version pins work. Maybe it will be easier then. |
🙌 thank you so much! You are totally right (as far as I understand it) that Poetry's solver is being overly strict. And yes the community will need to come to a solution. |
If you need some ammunition, this has been just fixed in the official docs: pypa/packaging.python.org#850 (see the linked core dev discussion). |
Hi Ned, any chance we can get a release with the updated metadata? The poetry 5.5 wheel still has this <4 thing in |
Just for completeness: this is in coverage 6.0. |
Thank you @nedbat much appreciated |
python_requires="<4"
creates issues with dependency solvers #1020