Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator #29

Closed
chandu0101 opened this issue Oct 2, 2015 · 12 comments
Closed

Navigator #29

chandu0101 opened this issue Oct 2, 2015 · 12 comments

Comments

@chandu0101
Copy link

web version of react-navigator - https://github.com/bh5-js/react-navigator

can we add this as dependency and expose via react-native-web ?

or can we copy the source to navigator folder( ofc if author of bh-react-navigator agree only) ?

WDYT ..

@necolas
Copy link
Owner

necolas commented Oct 3, 2015

I don't yet see how Navigator (no support for url state) makes sense on web, or would be preferable to react-router.

@chandu0101
Copy link
Author

I don't yet see how Navigator (no support for url state) makes sense on web

may be we don't need urls all the time!( because mobile app users are fine with it)

@necolas
Copy link
Owner

necolas commented Oct 4, 2015

That's not the majority case for web

@necolas
Copy link
Owner

necolas commented Oct 18, 2015

Going to close this for now, as react-router is a better choice:

  • react-router intends to support React Native
  • react-router can be used to control navigation of URL-less apps built with web technologies
  • bh5-js/react-navigator doesn't support URLs
  • bh5-js/react-navigator has no tests or active development

@grigio
Copy link

grigio commented Apr 23, 2016

React Router is not going to support React Native remix-run/react-router#743

@nunobbras
Copy link

What about adding the "new" NavigationExperimental?

@grigio
Copy link

grigio commented Apr 24, 2016

The missing part is NavigationStateUtils which is similar to the history api but different

@jmurzy
Copy link

jmurzy commented May 14, 2016

I agree with @necolas. Even though that's what the mobile app world looks like today, the URL is within the very fabric of our web and it shouldn't be taken away. Often people tend to take URLs for granted and advantages are not so pronounced.

I admit the native app ecosystem is not web-like, and you can argue that URLs aren't necessary and most people don't care, or so I thought until I put the URL-centric design in my native development toolbox.

I've just open sourced react-router-native that brings native support to react-router. Not sure if this is useful to you guys at the moment as it's under active development, but it's worth a look—and feedback is greatly appreciated.

🍺

@grigio
Copy link

grigio commented May 14, 2016

@jmurzy cool, have you tried the Example you show with react-native-web? It should work on Native and on the Web.
Personally i think the urls are still important, because allow to restore an app state without user interaction

@jmurzy
Copy link

jmurzy commented May 14, 2016

@grigio I haven't had a chance to try it with react-native-web. Let me know if you take a stab at it first.

Something to keep in mind is that react-router-native introduces two new route configuration elements to react-router, namely, <Tabs /> Route and <Stack /> Route. We have to test the behavior of these in the browser before making any promises.

🍺

@bitdivine
Copy link

@jmurzy react-router-native sounds promising. What is the current state of play? Is it usable by a react newbie?

Best wishes, Max

@ngduc
Copy link

ngduc commented Dec 5, 2016

FYI. I tried Navigator but it didn't work for me.

So I created a SimpleNavigator below which works across platforms & will keep improving it:
https://github.com/rhinos-app/rhinos-app-dev/blob/master/App/View/App.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants