-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator #29
Comments
I don't yet see how Navigator (no support for url state) makes sense on web, or would be preferable to react-router. |
may be we don't need urls all the time!( because mobile app users are fine with it) |
That's not the majority case for web |
Going to close this for now, as react-router is a better choice:
|
React Router is not going to support React Native remix-run/react-router#743 |
What about adding the "new" NavigationExperimental? |
The missing part is NavigationStateUtils which is similar to the history api but different |
I agree with @necolas. Even though that's what the mobile app world looks like today, the URL is within the very fabric of our web and it shouldn't be taken away. Often people tend to take URLs for granted and advantages are not so pronounced. I admit the native app ecosystem is not web-like, and you can argue that URLs aren't necessary and most people don't care, or so I thought until I put the URL-centric design in my native development toolbox. I've just open sourced react-router-native that brings native support to react-router. Not sure if this is useful to you guys at the moment as it's under active development, but it's worth a look—and feedback is greatly appreciated. 🍺 |
@jmurzy cool, have you tried the Example you show with react-native-web? It should work on Native and on the Web. |
@grigio I haven't had a chance to try it with react-native-web. Let me know if you take a stab at it first. Something to keep in mind is that react-router-native introduces two new route configuration elements to react-router, namely, 🍺 |
@jmurzy react-router-native sounds promising. What is the current state of play? Is it usable by a react newbie? Best wishes, Max |
FYI. I tried Navigator but it didn't work for me. So I created a SimpleNavigator below which works across platforms & will keep improving it: |
web version of react-navigator - https://github.com/bh5-js/react-navigator
can we add this as dependency and expose via react-native-web ?
or can we copy the source to navigator folder( ofc if author of bh-react-navigator agree only) ?
WDYT ..
The text was updated successfully, but these errors were encountered: