Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Hard-coded URLs don't include non-default namespaces in Stage 11-kubernetes-kuberhealhty-healthchecks #2776

Closed
kenafoster opened this issue Oct 15, 2024 · 0 comments · Fixed by #2779
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@kenafoster
Copy link
Contributor

Describe the bug

When doing a nebari render with a config file that includes a non-default namespace, I noticed an env variable (CHECK_URL) is included in the manifests of the 11-kubernetes-kuberhealthy-healthchecks that still points to the dev namespace

Expected behavior

The CHECK_URL domain needs to include the namespace where the checked resources are deployed

OS and architecture in which you are running Nebari

Mac OS Sequoia (Apple Silicon)

How to Reproduce the problem?

Do nebari render with a namespace other than dev configured

Command output

Below is a part of the rendered file `stages/11-kubernetes-kuberhealthy-healthchecks/manifests/comcast.github.io_v1_kuberhealthycheck_conda-store-http-check.yaml`.  The `metadata.namespace` is correct but the CHECK_URL env should be for the namespace, i.e. `spec.podSpec.containers[0].env[0].value=http://nebari-conda-store-server.custom:5000`

The rendered manifests for jupyterhub and Keycloak have similar issues for `CHECK_URL` ends


apiVersion: comcast.github.io/v1
kind: KuberhealthyCheck
metadata:
  name: conda-store-http-check
  namespace: custom
spec:
  podSpec:
    containers:
    - env:
      - name: CHECK_URL
        value: http://nebari-conda-store-server.dev:5000


### Versions and dependencies used.

Nebari 2024.9.1

### Compute environment

AWS

### Integrations

_No response_

### Anything else?

_No response_
@kenafoster kenafoster added type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Oct 15, 2024
@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Oct 15, 2024
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Oct 22, 2024
@viniciusdc viniciusdc added this to the 2024.9.2 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging a pull request may close this issue.

4 participants