feat: delay detector #3126
Merged
feat: delay detector #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
frol
approved these changes
Aug 11, 2020
|
|
||
| impl<'a> Drop for DelayDetector<'a> { | ||
| fn drop(&mut self) { | ||
| let elapsed = Instant::now() - self.started; |
There was a problem hiding this comment.
Suggested change
| let elapsed = Instant::now() - self.started; | |
| let elapsed = self.started.elapsed(); |
Comment on lines
+8
to
+9
| snapshots: Vec<((String, String), Duration)>, | ||
| last_snapshot: Option<(String, Instant)>, |
There was a problem hiding this comment.
Consider having structs with named fields as (String, String) is very hard to reason about.
| self.snapshot("end"); | ||
| } | ||
| self.snapshots.sort_by(|a, b| b.1.cmp(&a.1)); | ||
| for ((s1, s2), duration) in self.snapshots.drain(..) { |
There was a problem hiding this comment.
Why do we need to drain here?
Suggested change
| for ((s1, s2), duration) in self.snapshots.drain(..) { | |
| for ((s1, s2), duration) in &self.snapshots { |
| impl<'a> Drop for DelayDetector<'a> { | ||
| fn drop(&mut self) { | ||
| let elapsed = Instant::now() - self.started; | ||
| if elapsed > Duration::from_millis(50) && elapsed <= Duration::from_millis(500) { |
There was a problem hiding this comment.
To avoid typo-bugs, I suggest we swap the if statements, so we can use else branch.
SkidanovAlex
approved these changes
Aug 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 212 212
Lines 41377 41377
=======================================
Hits 36096 36096
Misses 5281 5281 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A delay detector that logs information when it detects that the node has spent too much time in some function. Fixes #3115.
Test plan
Manual test with a real node.