feat(client): Read snapshots for state #3092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make all reads from state use a read snapshot. Refactor RuntimeAdapter: methods that touch state now require creating a RuntimeStateAdapter. For now client and gc run in the same thread, so nothing should change for client. For view client it will be impossible to get storage errors if reading storage root succeeds. Test plan --------- Existing tests. Small sanity test.
mikhailOK
requested review from
evgenykuzyakov,
MaksymZavershynskyi,
olonho,
SkidanovAlex and
willemneal
as code owners
|
|
| fn apply_transactions_with_optional_storage_proof( | ||
| /// Validate state part that expected to be given state root with provided data. | ||
| /// Returns false if the resulting part doesn't match the expected one. | ||
| fn validate_state_part( |
There was a problem hiding this comment.
why is this part of RuntimeAdapter but not RuntimeStateAdapter?
There was a problem hiding this comment.
doesn't need state to validate
Comment on lines
+43
to
+44
| /// 3. Store does not use snapshots, so data can disappear between reads. | ||
| store: Store, |
There was a problem hiding this comment.
Not really safe, but maybe not terrible. Need to review all storage uses
|
|
||
| pub struct RocksDBOwningSnapshot { | ||
| db: Pin<Arc<RocksDB>>, | ||
| snapshot: Snapshot<'static>, |
There was a problem hiding this comment.
why do we do this instead of having a lifetime parameter?
There was a problem hiding this comment.
just to do less refactoring
bowenwang1996
approved these changes
Aug 13, 2020
SkidanovAlex
approved these changes
Aug 17, 2020
|
Please, revisit this PR and merge, close, or convert into a draft, so it is easier to see which PRs awaiting reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all reads from state use a read snapshot.
Refactor RuntimeAdapter: methods that touch state now require creating a
RuntimeStateAdapter.
For now client and gc run in the same thread, so nothing should change
for client. For view client it will be impossible to get storage errors
if reading storage root succeeds.
Test plan
Existing tests.
Small sanity test.