fix(pytest): use python proxy framework to isolate nodes instead of unix utilities #3076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the
local_network
stress test is to ensure the network functions well under the condition that a random node occasionally loses contact with the rest of the network (i.e. experiences a "local network failure"). Previously this test was implemented by restricting access to network interfaces of specific process ids at the OS level. This solution was a little hacky, platform dependent, and not entirely reliable. We now have a proxy framework as part ofpytest
which is exactly meant to change (or drop) messages between nodes. We now make use of this framework in thelocal_network
stress test instead of using the Unix utilities.