fix: disable epoch info gc for now #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Kouprin can you help fix the store validator code? |
bowenwang1996
requested review from
evgenykuzyakov,
frol and
MaksymZavershynskyi
as code owners
|
@bowenwang1996 please check if could we enable
|
Kouprin
approved these changes
Jul 7, 2020
|
@Kouprin I don't see why we cannot enable it. Do you want to do it in another PR or in this one? |
frol
approved these changes
Jul 7, 2020
I have no preferences. It might be better to have a separate PR as for another purpose but it's up to you. |
SkidanovAlex
approved these changes
Jul 7, 2020
|
@SkidanovAlex no Cargo.lock change after merging with master :) |
bowenwang1996
added a commit
that referenced
this pull request
Jul 7, 2020
Currently we would garbage epoch information right after the epoch switch, which causes many problems including rpc not able to fetch chunks/blocks in the past epoch, not able to verify blocks in the past epoch, etc. I think it is safer to disable it for now and maybe consider implementing it properly when we redo the syncing code.
chefsale
pushed a commit
that referenced
this pull request
Jul 8, 2020
Currently we would garbage epoch information right after the epoch switch, which causes many problems including rpc not able to fetch chunks/blocks in the past epoch, not able to verify blocks in the past epoch, etc. I think it is safer to disable it for now and maybe consider implementing it properly when we redo the syncing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we would garbage epoch information right after the epoch switch, which causes many problems including rpc not able to fetch chunks/blocks in the past epoch, not able to verify blocks in the past epoch, etc. I think it is safer to disable it for now and maybe consider implementing it properly when we redo the syncing code.