Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write genesis to storage on restart #3151

Closed
mikhailOK opened this issue Aug 12, 2020 · 0 comments · Fixed by #3470
Closed

Don't write genesis to storage on restart #3151

mikhailOK opened this issue Aug 12, 2020 · 0 comments · Fixed by #3470
Assignees
@mikhailOK
Labels
A-chain Area: Chain, client & related A-storage Area: storage and databases
Milestone
Mainnet Guild 202...

Comments

@mikhailOK
Copy link
Contributor

Discovered in #3065. It's faster after the fix, but we should also not write genesis state again.
@weekly-digest weekly-digest bot mentioned this issue Aug 14, 2020
Closed
@bowenwang1996 bowenwang1996 added A-chain Area: Chain, client & related A-storage Area: storage and databases labels Aug 31, 2020
mikhailOK added a commit that referenced this issue Oct 8, 2020
@mikhailOK
fix(genesis): Don't write genesis records on restart
b4148b2 
- When the node starts for the first time, save the hash of genesis in
storage, and assert on every restart that same genesis is used.

- Save the genesis state roots on first start, and don't rebuild the
trie on every restart.

Fixes #3151
Fixes #3063

Test plan
---------
existing tests
mikhailOK added a commit that referenced this issue Oct 8, 2020
@mikhailOK
fix(genesis): Don't write genesis records on restart
966c33f 
- When the node starts for the first time, save the hash of genesis in
storage, and assert on every restart that same genesis is used.

- Save the genesis state roots on first start, and don't rebuild the
trie on every restart.

Fixes #3151
Fixes #3063

Test plan
---------
existing tests
mikhailOK added a commit that referenced this issue Oct 8, 2020
@mikhailOK
fix(genesis): Don't write genesis records on restart
ab9f972 
- When the node starts for the first time, save the hash of genesis in
storage, and assert on every restart that same genesis is used.

- Save the genesis state roots on first start, and don't rebuild the
trie on every restart.

Fixes #3151
Fixes #3063

Test plan
---------
existing tests
@mikhailOK mikhailOK mentioned this issue Oct 8, 2020
Merged
mikhailOK added a commit that referenced this issue Oct 8, 2020
@mikhailOK
fix(genesis): Don't write genesis records on restart (#3470)
8448752 
- When the node starts for the first time, save the hash of genesis in
storage, and assert on every restart that same genesis is used.

- Save the genesis state roots on first start, and don't rebuild the
trie on every restart.

Fixes #3151
Fixes #3063

Test plan
---------
existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikhailOK mikhailOK

Labels
A-chain Area: Chain, client & related A-storage Area: storage and databases
Projects
None yet
Milestone
Mainnet Guild 2020.09.21-2020.10.02
Development

Successfully merging a pull request may close this issue.

fix(genesis): Don't write genesis records on restart near/nearcore
3 participants
@mikhailOK @bowenwang1996 @MaksymZavershynskyi