Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sample Grafana dashboard #8

Merged
merged 2 commits into from
Jan 16, 2023
Merged

feat: Sample Grafana dashboard #8

merged 2 commits into from
Jan 16, 2023

Conversation

ilchebedelovski
Copy link
Contributor

What does this PR do?

This is a sample Grafana dashboard which is based on the sample Prometheus app that already exists on the repo. With this code, the metrics that are exposed from the sample Prometheus app are visualized in Grafana.

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have upgraded the changelog according to the nature of the feature that I am adding to this Pull Request.

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jan 13, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 0.1.0 milestone Jan 13, 2023
julianxhokaxhiu
julianxhokaxhiu previously approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thank you!

julianxhokaxhiu
julianxhokaxhiu approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition on the docs. LGTM

@ilchebedelovski ilchebedelovski merged commit 1bb35e2 into main Jan 16, 2023
@ilchebedelovski ilchebedelovski deleted the feature/sample-grafana-dashboard branch January 16, 2023 09:46
@nearform-renovate-app nearform-renovate-app bot mentioned this pull request Jan 16, 2023
Merged
@renovate renovate bot mentioned this pull request Jul 23, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Aug 20, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@ilchebedelovski ilchebedelovski

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilchebedelovski @julianxhokaxhiu