Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable sync policy for ArgoCD #56

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

mile-misan
Copy link
Contributor

What does this PR do?

This PR adds parameter for sync policy in the application helm template. Default values stayed the same but now they are defined in values.yaml of app-of-apps chart.
Sync policy can be controlled in 2 ways:

  • for all applications by changing default values
  • per application by overriding default values in apps section, for example, to use manual sync omit automated section in the sync policy definition:
  istio-ingressgateway:
    name: istio-ingressgateway
    path: addons/istio/ingressgateway/
    targetNamespace: istio-ingress
    syncPolicy:
      syncOptions:
        - CreateNamespace=true

Also, this PR moved istio-ingress out of Istio sync-wave which removed the need to use namespace manifest for istio-ingress app.

Related issues

Closes #39

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have upgraded the changelog according to the nature of the feature that I am adding to this Pull Request.

@julianxhokaxhiu julianxhokaxhiu changed the title Feature/configurable sync policy feat: Configurable sync policy for ArgoCD Feb 6, 2023
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Feb 6, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 0.1.0 milestone Feb 6, 2023
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@mile-misan mile-misan merged commit f2730e8 into main Feb 6, 2023
@mile-misan mile-misan deleted the feature/configurable-sync-policy branch February 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ArgoCD] Make sync policy configurable in addons application manifest
2 participants