Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all resources when deleting indexer #346

Closed
4 tasks done
Tracked by #621 ...
morgsmccauley opened this issue Oct 31, 2023 · 2 comments
Closed
4 tasks done
Tracked by #621 ...

Delete all resources when deleting indexer #346

morgsmccauley opened this issue Oct 31, 2023 · 2 comments
Assignees

Comments

@morgsmccauley
Copy link
Collaborator

morgsmccauley commented Oct 31, 2023

Deleting the indexer from the UI will only remove it from the registry contract, but all the infrastructure resources will remain. The following should be deleted along with the registry entry:

  • Related redis keys
  • Hasura configuration
  • Database schema

Tasks

Preview Give feedback
  1. morgsmccauley
@morgsmccauley
Copy link
Collaborator Author

This may be tricky with Coordinator viewing the snapshots of the Registry at single points in time. Coordinator compares the registry to the system directly, so will only know of a deletion if the system is actually running that deleted indexer, but if we restart during a deletion, the event will be missed.

We may need to introduce some persistent state which Coordinator can refer to as to gain more awareness of these events.

@morgsmccauley
Copy link
Collaborator Author

Another perhaps more straight forward approach would be to query Hasura/Postgres to the current provisioning state, which could be compared to the registry. This removes the need for capturing specific point-in-time events, and allows us to simply synchronise actual/desired states exactly like we are for Block streams/Excutors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants