utils: add a few more examples and tests to MaybeValidated #5346
Conversation
Extend existing and introduce new examples of MaybeValidated usage which test the type a bit more extensively.
mina86
requested review from
bowenwang1996,
frol,
matklad and
mm-near
as code owners
| /// assert_eq!(Ok(true), value_as_ref.validate_with::<(), _>(|&&v| Ok(v == 42))); | ||
| /// assert!(value_as_ref.is_validated()); | ||
| /// assert!(!value.is_validated()); | ||
| /// ``` |
There was a problem hiding this comment.
I tend to think that doctests are not worth it for non-library crates in general. The problem with doctests is that they are notoriously slow to compile and run, as each doctest is compiled as a separate binary. For example, in rust-analyzer, removing doctest = false from Cargo.tomls increases the wall-clock time for the testsuite from 5 seconds to 10 seconds, and ra doesn't even have doctets.
OTOH, our tests are already pretty slow, and we dont' add doctest=false to cargo.tomls, so this isn't a regression for nearcore. So, no strong opinion here!
There was a problem hiding this comment.
I don’t have an opinion either way. Wasn’t really aware that there was noticeable compile-time cost. I’m happy to rewrite it as [test].
There was a problem hiding this comment.
Nah, I guess let's leave it as is -- we do seem to have some doctests scattered elsewhere. Although, once #4490 is fixed, it makes sense to quantify how bad are doctests for our case. Maybe by that time rust-lang/rust#75341 is fixed, which would be ideal :)
Extend existing and introduce new examples of MaybeValidated usage
which test the type a bit more extensively.