You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When there is no chunk at some height, chunk header is just copied from previous block and Chain::get_apply_chunk_job_old_chunk is called.
Inside it, RuntimeAdapter::apply_transactions is called, which may look like that transactions and receipts are applied, but in fact it is not the case after ProtocolFeature::FixApplyChunks. It means that a bunch of fields is not needed, like receipts, transactions, gas_price, block_timestamp, so we can simplify the logic in such case.
The only updates which can happen are Runtime::update_validator_accounts and Runtime::apply_migrations, and they must be preserved. But I suggest to investigate moving them to their own Runtime method, potentially we can remove bunch of code after that.
More context near.zulipchat.com/#narrow/stream/295302-general/topic/.E2.9C.94.20gas.20price.20inconsistency/near/394894144
The text was updated successfully, but these errors were encountered:
When there is no chunk at some height, chunk header is just copied from previous block and
Chain::get_apply_chunk_job_old_chunk
is called.Inside it,
RuntimeAdapter::apply_transactions
is called, which may look like that transactions and receipts are applied, but in fact it is not the case afterProtocolFeature::FixApplyChunks
. It means that a bunch of fields is not needed, likereceipts
,transactions
,gas_price
,block_timestamp
, so we can simplify the logic in such case.The only updates which can happen are
Runtime::update_validator_accounts
andRuntime::apply_migrations
, and they must be preserved. But I suggest to investigate moving them to their ownRuntime
method, potentially we can remove bunch of code after that.More context near.zulipchat.com/#narrow/stream/295302-general/topic/.E2.9C.94.20gas.20price.20inconsistency/near/394894144
The text was updated successfully, but these errors were encountered: