-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run near-sdk-rs tests in nearcore #2959
Comments
@nearmax @ailisp @frol @vgrichina I don't have access to our travis. near-sdk-rs is hosted on travis and our nearcore is on buildkite. I think the best way to make this happen is to migrate near-sdk-rs to buildkite as well and than trigger the pipeline from nearcore. Does that makes sense? As well could somebody give me access to travis? |
Login with github and opening the right pages did it. I plan to migrate near-sdk-rs to buildkite than. Let me know if that works for you? |
Why do we need to migrate near-sdk-rs to buildkite? Will the failure on near-sdk-rs happening on nearcore commit fail nearcore CI instead of near-sdk-rs then? |
So I would move near-sdk-rs to a seperate pipeline which would be triggered on commits in near-sdk-rs repo, but if you commit to nearcore it will also run the near-sdk-rs pipeline as a step to make sure that is still passing as well. Getting that to work to trigger travis from buildkite would be pretty hacky, so maybe better to move it. |
And yes failure on near-sdk-rs happening on nearcore commit fail nearcore CI and on near-sdk-rs. Essentially both, until it gets fixed. |
Created the pipeline on buildkite: https://buildkite.com/nearprotocol/near-sdk-rs/builds/10#730aa905-b845-4195-8215-1af5641c0d60 |
@chefsale will it fail near-sdk-rs on a PR to nearcore? |
Hmm, not sure what is the exact question? If you push a change which breaks near-sdk-rs compatability it will fail but on the PR on nearcore, it shouldn't be blocking an near-sdk-rs PR, now it will as the near-sdk-rs is broken. |
Near-sdk-rs runs their own tests now on buildkite as well: near/near-sdk-rs#199. Last step is to make sure that we trigger the pipeline from nearcore. |
Now sdk tests are being ran inside nearcore as well: https://buildkite.com/nearprotocol/nearcore/builds/2450. |
cc: @nearmax @frol @SkidanovAlex you will have to make sure that SDK is now fixed and compatible otherwise tests will be failing. |
Assigning this fixing near-sdk-rs to @evgenykuzyakov and re-opening. |
near-sdk-rs tests are fixed near/near-sdk-rs#200 |
Currently, nearcore sometimes breaks near-sdk-rs and we find it out only when someone pushes a change to near-sdk-rs and triggers the CI. Sometimes we only find it out more than a week later. We need to run near-sdk-rs tests on nearcore commits to prevent this from happening.
This addresses our recurrent discussion on how we make sure nearcore is not breaking dependent repos. CC @SkidanovAlex , @olonho , @chefsale
The text was updated successfully, but these errors were encountered: