Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run near-sdk-rs tests in nearcore #2959

Closed
MaksymZavershynskyi opened this issue Jul 9, 2020 · 13 comments
Closed

Run near-sdk-rs tests in nearcore #2959

MaksymZavershynskyi opened this issue Jul 9, 2020 · 13 comments
Assignees
Labels
A-CI Area: Continuous Integration T-SRE Team: issues relevant to the SRE team

Comments

@MaksymZavershynskyi
Copy link
Contributor

Currently, nearcore sometimes breaks near-sdk-rs and we find it out only when someone pushes a change to near-sdk-rs and triggers the CI. Sometimes we only find it out more than a week later. We need to run near-sdk-rs tests on nearcore commits to prevent this from happening.

This addresses our recurrent discussion on how we make sure nearcore is not breaking dependent repos. CC @SkidanovAlex , @olonho , @chefsale

@MaksymZavershynskyi MaksymZavershynskyi added the A-CI Area: Continuous Integration label Jul 9, 2020
@chefsale
Copy link
Contributor

@nearmax @ailisp @frol @vgrichina I don't have access to our travis. near-sdk-rs is hosted on travis and our nearcore is on buildkite. I think the best way to make this happen is to migrate near-sdk-rs to buildkite as well and than trigger the pipeline from nearcore. Does that makes sense? As well could somebody give me access to travis?

@chefsale
Copy link
Contributor

Login with github and opening the right pages did it. I plan to migrate near-sdk-rs to buildkite than. Let me know if that works for you?

@frol
Copy link
Collaborator

frol commented Jul 10, 2020

Why do we need to migrate near-sdk-rs to buildkite? Will the failure on near-sdk-rs happening on nearcore commit fail nearcore CI instead of near-sdk-rs then?

@chefsale
Copy link
Contributor

So I would move near-sdk-rs to a seperate pipeline which would be triggered on commits in near-sdk-rs repo, but if you commit to nearcore it will also run the near-sdk-rs pipeline as a step to make sure that is still passing as well. Getting that to work to trigger travis from buildkite would be pretty hacky, so maybe better to move it.

@chefsale
Copy link
Contributor

And yes failure on near-sdk-rs happening on nearcore commit fail nearcore CI and on near-sdk-rs. Essentially both, until it gets fixed.

@chefsale
Copy link
Contributor

@frol
Copy link
Collaborator

frol commented Jul 10, 2020

@chefsale will it fail near-sdk-rs on a PR to nearcore?

@chefsale
Copy link
Contributor

Hmm, not sure what is the exact question? If you push a change which breaks near-sdk-rs compatability it will fail but on the PR on nearcore, it shouldn't be blocking an near-sdk-rs PR, now it will as the near-sdk-rs is broken.

@chefsale
Copy link
Contributor

Near-sdk-rs runs their own tests now on buildkite as well: near/near-sdk-rs#199. Last step is to make sure that we trigger the pipeline from nearcore.

@chefsale
Copy link
Contributor

Now sdk tests are being ran inside nearcore as well: https://buildkite.com/nearprotocol/nearcore/builds/2450.

@chefsale
Copy link
Contributor

cc: @nearmax @frol @SkidanovAlex you will have to make sure that SDK is now fixed and compatible otherwise tests will be failing.

@MaksymZavershynskyi
Copy link
Contributor Author

Assigning this fixing near-sdk-rs to @evgenykuzyakov and re-opening.

@bowenwang1996
Copy link
Collaborator

near-sdk-rs tests are fixed near/near-sdk-rs#200

@chefsale chefsale self-assigned this Jul 13, 2020
@chefsale chefsale added the T-SRE Team: issues relevant to the SRE team label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Continuous Integration T-SRE Team: issues relevant to the SRE team
Projects
None yet
Development

No branches or pull requests

5 participants