Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test zero downtime upgrade for validators #2840

Closed
bowenwang1996 opened this issue Jun 12, 2020 · 2 comments
Closed

Test zero downtime upgrade for validators #2840

bowenwang1996 opened this issue Jun 12, 2020 · 2 comments
Assignees
Labels
A-testing Area: Unit testing / integration testing

Comments

@bowenwang1996
Copy link
Collaborator

In near/docs#341, @ilblackdragon described the way for validators to seamlessly upgrade their nodes (by spinning up a new node and stake with a new key). However, we have not yet done any testing to make sure that this works in practice. There should at least be some sanity test to show that the procedure described in near/docs#341 isn't trivially broken.

@bowenwang1996 bowenwang1996 added the A-testing Area: Unit testing / integration testing label Jun 12, 2020
@bowenwang1996 bowenwang1996 self-assigned this Jun 12, 2020
@mfornet
Copy link
Member

mfornet commented Jun 12, 2020

I can attest this doesn't work today. AccountId/ValidatorKey is not propagated properly when new node with the same account is announced.

Also, in the network level code it is assumed that each account id is associated with a at most one node_key at all times. But we should relax this condition a bit to be: Each account id is associated with at most one pair (node_key, epoch_id). This will require that the network layer should be aware of the current epoch, which is something undesired.

@bowenwang1996
Copy link
Collaborator Author

Fixed in #2846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Area: Unit testing / integration testing
Projects
None yet
Development

No branches or pull requests

2 participants