-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update replay-headers to report differences in rewards and kickouts #12048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12048 +/- ##
==========================================
- Coverage 71.42% 71.40% -0.03%
==========================================
Files 814 814
Lines 163933 164040 +107
Branches 163933 164040 +107
==========================================
+ Hits 117097 117132 +35
- Misses 41704 41774 +70
- Partials 5132 5134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have been using the
neard replay-headers
command to simulate validator rewards and kickouts computations for past epochs to check the difference between original and replayed runs.Submitting the new version of the command we have been using for simulating the reward/kickout computations for chunk validators in the context of #11900.
This version no longer assumes that the original and replayed values are the same and prints the diffs in kickouts and rewards (stakes).