Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update replay-headers to report differences in rewards and kickouts #12048

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

tayfunelmas
Copy link
Contributor

We have been using the neard replay-headers command to simulate validator rewards and kickouts computations for past epochs to check the difference between original and replayed runs.

Submitting the new version of the command we have been using for simulating the reward/kickout computations for chunk validators in the context of #11900.

This version no longer assumes that the original and replayed values are the same and prints the diffs in kickouts and rewards (stakes).

@tayfunelmas tayfunelmas requested a review from a team as a code owner September 5, 2024 11:22
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/state-viewer/src/replay_headers.rs Outdated Show resolved Hide resolved
tools/state-viewer/src/replay_headers.rs Outdated Show resolved Hide resolved
tools/state-viewer/src/replay_headers.rs Show resolved Hide resolved
tools/state-viewer/src/replay_headers.rs Show resolved Hide resolved
tools/state-viewer/src/replay_headers.rs Outdated Show resolved Hide resolved
@tayfunelmas tayfunelmas added this pull request to the merge queue Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 71.40%. Comparing base (051289d) to head (33eac8f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tools/state-viewer/src/replay_headers.rs 0.00% 112 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12048      +/-   ##
==========================================
- Coverage   71.42%   71.40%   -0.03%     
==========================================
  Files         814      814              
  Lines      163933   164040     +107     
  Branches   163933   164040     +107     
==========================================
+ Hits       117097   117132      +35     
- Misses      41704    41774      +70     
- Partials     5132     5134       +2     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (-0.01%) ⬇️
db-migration 0.17% <0.00%> (-0.01%) ⬇️
genesis-check 1.28% <0.00%> (-0.01%) ⬇️
integration-tests 38.55% <0.00%> (-0.03%) ⬇️
linux 71.19% <0.00%> (-0.03%) ⬇️
linux-nightly 70.97% <0.00%> (-0.04%) ⬇️
macos 54.02% <0.00%> (+0.57%) ⬆️
pytests 1.54% <0.00%> (-0.01%) ⬇️
sanity-checks 1.34% <0.00%> (-0.01%) ⬇️
unittests 65.19% <0.00%> (-0.02%) ⬇️
upgradability 0.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 1555d7b Sep 6, 2024
28 of 29 checks passed
@tayfunelmas tayfunelmas deleted the replay-headers2 branch September 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants