Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled test: test_storage_proof_size_soft_limit #10864

Closed
Ekleog-NEAR opened this issue Mar 22, 2024 · 1 comment
Closed

Disabled test: test_storage_proof_size_soft_limit #10864

Ekleog-NEAR opened this issue Mar 22, 2024 · 1 comment
Labels
A-storage Area: storage and databases T-core Team: issues relevant to the core team

Comments

@Ekleog-NEAR
Copy link
Collaborator

Ekleog-NEAR commented Mar 22, 2024

As part of #10852, we disabled test_storage_proof_size_soft_limit

This is likely because we no longer fetch the contract wasm from trie upon each execution, and so the test stops hitting the storage proof limit.

In order to fix this, we need to define how statelessnet is expected to deal with contract compilation. Are validators expected to know all the contracts for all shards and keep a compiled cache, or should chunk producers supply validators with contract each time? (in which case validators would need quite a bit more processing power than today, because compiling a contract is probably the slowest operation in our system and we currently avoid most of it)

Depending on the answer, either we should adjust the test to use more storage / lower the limit, or we should re-introduce the early loading of wasm code just for stateless chunk producers.

Discussion also happened on https://near.zulipchat.com/#narrow/stream/295302-general/topic/test_storage_proof_size_soft_limit

cc @shreyan-gupta

@Ekleog-NEAR Ekleog-NEAR added the A-storage Area: storage and databases label Mar 22, 2024
@Ekleog-NEAR Ekleog-NEAR added the T-core Team: issues relevant to the core team label May 17, 2024
@Longarithm
Copy link
Member

Works again since #11185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: storage and databases T-core Team: issues relevant to the core team
Projects
None yet
Development

No branches or pull requests

2 participants