fix: support #[handle_result] in ABI macro
#858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
changed the title
#[handle_result] in ABI macro#[handle_result] in ABI macro
austinabell
approved these changes
Jul 12, 2022
Comment on lines
+131
to
+139
| let ty = if let Some(ty) = utils::extract_ok_type(ty) { | ||
| ty | ||
| } else { | ||
| return syn::Error::new_spanned( | ||
| ty, | ||
| "Function marked with #[handle_result] should have return type Result<T, E> (where E implements FunctionError).", | ||
| ) | ||
| .into_compile_error(); | ||
| }; |
There was a problem hiding this comment.
feels like this is code duplication from the extraction from non-abi codegen, but probably fine for now
There was a problem hiding this comment.
Yep, I kind of feel like the bindgen macro needs a pre-processing step that would do all of these "type" checks (#[handle_result], #[callback_vec] etc) and produce a well-formed model. In this case, it would look something like this:
enum BindgenReturnType {
Regular(Ident),
HandleResult { ident: Ident, ok_type: Ident, err_type: Ident },
}
struct BindgenFunction {
...
return_type: BindgenReturnType
}So that we can just safely use these models in later steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853