Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace internal account id type with the near-account-id crate #1105

Closed
Tracked by #946
frol opened this issue Oct 30, 2023 · 5 comments · Fixed by #1108
Closed
Tracked by #946

refactor: Replace internal account id type with the near-account-id crate #1105

frol opened this issue Oct 30, 2023 · 5 comments · Fixed by #1108
Labels
good first issue Good for newcomers

Comments

@frol
Copy link
Collaborator

frol commented Oct 30, 2023 •
edited
Loading

Replace copy-pasta code: https://github.com/near/near-sdk-rs/blob/master/near-sdk/src/types/account_id.rs with https://crates.io/crates/near-account-id/1.0.0-alpha.1 (1.0.0-alpha.2 or newer)
@frol frol added the good first issue Good for newcomers label Oct 30, 2023
@Asymtode712
Copy link

I want to work on it. Please assign me

@frol
Copy link
Collaborator Author

frol commented Oct 30, 2023

@Asymtode712 Please, go ahead!

@Asymtode712 Asymtode712 mentioned this issue Oct 30, 2023
Closed
@Asymtode712
Copy link

@frol Please review my PR and suggests if there are some changes to be made.

This was referenced Nov 2, 2023
Closed
Closed
@frol
Copy link
Collaborator Author

frol commented Nov 2, 2023

@Asymtode712 Any updates? Do you plan to keep working on it?

@frol frol mentioned this issue Nov 3, 2023
Merged
@Asymtode712 Asymtode712 removed their assignment Nov 3, 2023
@ruseinov
Copy link
Collaborator

@frol This seems already done.

@frol frol mentioned this issue Nov 15, 2023
Merged
@frol frol closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: migrate to near_account_id iho/near-sdk-rs
Update account_id.rs
3 participants
@frol @ruseinov @Asymtode712