Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for upgrading borsh dependency to 0.10 in the next release. #1083

Closed
riversyang opened this issue Sep 15, 2023 · 2 comments
Closed

Comments

@riversyang
Copy link

Hi there, Octopus Network is working on near-ibc which will enable IBC based cross-chain bridge on NEAR protocol.

We plan to integrate the latest ibc-rs. The latest version of ibc-rs to be released has a dependency on borsh 0.10 (due to the requirements of other dependencies, see this issue), but the current release version (4.1.1) of near-sdk-rs has a dependency on borsh 0.9.

I looked at the source code of the latest near-sdk-rs, and I found that the borsh dependency is still 0.9. So this will affect the release of the near-ibc project.

I'm wondering why this dependency is still not upgraded in near-sdk-rs, is there any special consideration? If not, we would like to see borsh upgraded to 0.10 in the next release of near-sdk-rs.

BTW. We also expect the env::ed25519_verify function to be available in the next release of near-sdk-rs, which will help us reduce the gas consumption of signature verification in tendermint light client in near-ibc contract, which is also very important for near-ibc.

Thank you!

@frol
Copy link
Collaborator

frol commented Sep 15, 2023

@riversyang Thanks for flagging it! There is a major push to borsh 1.0, and we already have a draft PR #1075 that checks that 1.0-alpha works as expected!

@frol
Copy link
Collaborator

frol commented Oct 14, 2023

#1075 upgraded borsh to 1.0

@frol frol closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants