Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to switch to from actix to tokio runtime #330

Open
khorolets opened this issue Dec 14, 2022 · 0 comments
Open

Try to switch to from actix to tokio runtime #330

khorolets opened this issue Dec 14, 2022 · 0 comments
Assignees

Comments

@khorolets
Copy link
Member

At the moment we mix actix and tokio runtimes.

Historically diesel works synchronously while we need it asynchronous. We use actix-diesel library because the alternative tokio-diesel just didn't work. That's the reason we wrap our main with [actix::main], but everywhere else we explicitly use tokio.

It would be nice to try to switch to tokio completely to avoid mixing things up and make our codebase and dependencies a bit clearer.

It might not work and we could live with that, so this issue is "like-to-have" more that "must-have"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants