Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When near-api-js updates TypeScript dependency, my project breaks #368

Closed
chadoh opened this issue Jul 22, 2020 · 1 comment
Closed

When near-api-js updates TypeScript dependency, my project breaks #368

chadoh opened this issue Jul 22, 2020 · 1 comment
Labels
bug Something isn't working P2 Pretty important

Comments

@chadoh
Copy link
Contributor

chadoh commented Jul 22, 2020

Describe the bug
Recently (maybe a3e587b74), NAJ updated its TypeScript dependency. This caused the lib/index.d.ts file to use syntax that was only supported by TS version greater than 3.8:

 Syntax not supported by TS version < 3.8
 export * as aliasName from './path/to/the/file'

It took partners using an older version of TS a long time to track down and fix the issue.

NAJ should play more nicely with everyone relying on an older TS version, and give expectable deprecation warnings when support for a newer TS version is added.

Additional context
It looks like [this is a known frustration with TypeScript](microsoft/TypeScript#31907) that should ideally be fixed by the TypeScript team. However, the TS team did provide a rudimentary means for library authors to control this in September 2018: microsoft/TypeScript#26568

@chadoh chadoh added bug Something isn't working P2 Pretty important labels Jul 22, 2020
@vikinatora
Copy link
Collaborator

Closing as it's not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Pretty important
Projects
None yet
Development

No branches or pull requests

2 participants