Old NEAR contracts won't compile with the new borsh re-exported from near-sdk-rs ("Could not find borsh")

[fadeevab]

I hit the issue with the new near-sdk-rs: near/near-sdk-rs#1129

I tried to compile my project with near-sdk-rs 5.0.0-alpha.1 because of this issue near/near-sdk-rs#1119, however, build fails with the errors:

error: proc-macro derive panicked
 --> src/main.rs
  |
6 | #[derive(BorshSerialize, BorshDeserialize)]
  |          ^^^^^^^^^^^^^^
  |
  = help: message: called `Result::unwrap()` on an `Err` value: Could not find `borsh` in `dependencies` or `dev-dependencies` in `/home/xxxx/yyyyy/Cargo.toml`!

BEFORE, a simple import of near_sdk::borsh::self was enough to make derive macro work.
NOW, either a direct borsh import is needed (thus, re-export from near-sdk becomes useless), or #[borsh(crate = "near_sdk::borsh")] is necessary for every structure (as suggested by @frol, near/near-sdk-rs#1129 (comment))

[frol]

This new behavior is by design and serde does the same.

[fadeevab]

@frol in this case, borsh re-export loses its sense, because using the borsh crate directly will be more convenient. I thought that re-export had to make things more convenient, not more complicated. I have 20 structures, I don't wanna add annotations to each one.

[frol]

@fadeevab Re-export also keeps things consistent. Ideally, I don't want to derive neither serde nor borsh manually, so I at the back of my mind I am thinking how to achieve that without introducing too much magic to it.

[fadeevab]

@frol :) One quick workaround came to my mind: falling back to near_sdk::borsh reexport if near_sdk has found - somewhere around these lines:

borsh-rs/borsh-derive/src/internals/cratename.rs

Line 21 in 19e9fee

let name = &crate_name(BORSH).unwrap();

Little bit dirty :) However, intuitively, if I already use near_sdk::borsh::BorshDeserialize, I expect that #derive just works... Also, another justification to do so: borsh is already under the near (GitHub) account and ecosystem.

All that is not critical of course.

[frol]

@fadeevab Given that there are more than just borsh that needs to be configured near/near-sdk-rs#1142, I don't think this change is worth it.