Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitivity on Alternative Hosts field - is it possible to make case insesntive #618

Open
simon-kanz opened this issue Sep 11, 2024 · 4 comments
Assignees
Labels
bug Fixes problems or reduces technical debt

Comments

@simon-kanz
Copy link

Hi All,

Thanks for this plugin, we've used it to great success however have noticed that we have an issue where some of our users have capital letters in their email addresses.

Scenario -
User email address: [email protected]
Email address matches in Zoom and Moodle using the specific format above.

Our LMS team adds Jo as an alternative host on a call using the email address "[email protected]"
When Jo tries to access the meeting, they will get the blue "Join Meeting" button and be unable to start the call.
If Jo attempts to start the meeting they'll then get an error on the Zoom side saying "You have a meeting that is currently in-progress. Please end it to start a new meeting"
Screenshot 2024-09-11 at 2 58 27 PM

Our LMS team then updates the alternative host to use the correct format "[email protected]" as an alternative host.
When Jo tries to access the meeting, they will get the green "Start Meeting" button and can start the call successfully.


For the moment we've asked the LMS team to ensure that they use the correct format for the users, however, they are not always aware of what the exact format should be. Is it possible to make this lookup case insensitive? I'm not sure if this is a problem on Zoom's side or the plugin itself

@github-project-automation github-project-automation bot moved this to Needs triage in mod_zoom Workflow Sep 11, 2024
@jrchamp jrchamp moved this from Needs triage to To Do in mod_zoom Workflow Sep 12, 2024
@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Sep 12, 2024
@jrchamp
Copy link
Collaborator

jrchamp commented Sep 12, 2024

Hi @simon-kanz,

This does seem like a bug that we can address in the plugin. I hope that Zoom is already doing a case-insensitive lookup when we request information for a user's account. I think we were assuming that the email addresses would always match and PHP string comparisons are, in general, case-sensitive. So what we should probably do (in the plugin) is programmatically lowercase all email addresses so that PHP's case-sensitive string comparisons do not get confused.

@simon-kanz
Copy link
Author

Hi @jrchamp
I've got an open support request with Zoom to find out if their service is case-sensitive. If you were to update to use case-insenstive lookups, it's likely that it would break the lookup for any user who has mixed cases in their email!

Hopefully Zoom get back to us soon and advise that email is case-insenstive and your recommendation would be solve the issue.

@simon-kanz
Copy link
Author

Hi @jrchamp
Zoom support have responded to us, saying that their username and email fields are not case-sensitive.
That likely means that you could update the logic to lowercase all email addresses

@jrchamp
Copy link
Collaborator

jrchamp commented Sep 26, 2024

Thanks @simon-kanz! That's great to know. We'll add this to our worklog and prioritize it appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Status: To Do
Development

No branches or pull requests

4 participants