Sessions report shows duplicate entries for non-host users

[bunkerskyi]

Hello. We have problems, users who use the Moodle mobile app don't present in the Sessions report. I guess that happening because the join link in the mobile app doesn't have the uname parameter. Is that might be true?

I made this assumption, that the uname is critical, according to this comment and this PR

[jrchamp]

Thanks @bunkerskyi, we'll do some testing to see if we can reproduce the issue.

For any enterprising developer, here's the code flow:

Clicking the join meeting button in the Moodle Mobile app:

moodle-mod_zoom/templates/mobile_view_page_latest.mustache

Line 54 in 54313db

<ion-button class="ion-margin" expand="block" color="light" core-site-plugins-call-ws name="mod_zoom_grade_item_update" [params]="{zoomid: <% cmid %>}" [preSets]="{getFromCache: 0, saveToCache: 0}" (onSuccess)="loadMeeting($event)">

Calling the mod_zoom_grade_item_update function registered in services.php:

moodle-mod_zoom/db/services.php

Lines 43 to 46 in 54313db

	'mod_zoom_grade_item_update' => [
	'classname' => 'mod_zoom\external',
	'methodname' => 'grade_item_update',
	'classpath' => 'mod/zoom/classes/external.php',

An external function provides the same join URL for Mobile, so it should already have the uname specified:

moodle-mod_zoom/classes/external.php

Lines 196 to 203 in 54313db

	// Call load meeting function, do not use start url on mobile.
	$meetinginfo = zoom_load_meeting($params['zoomid'], $context, $usestarturl = false);
	// Pass url to join zoom meeting in order to redirect user.
	$result = [];
	if ($meetinginfo['nexturl']) {
	$result['status'] = true;
	$result['joinurl'] = $meetinginfo['nexturl']->__toString();

If the registered function returns success, a new window is opened using the returned join URL:

moodle-mod_zoom/classes/output/mobile.php

Line 90 in 54313db

'javascript' => "this.loadMeeting = function(result) { window.open(result.joinurl, '_system'); };",

[jrchamp]

Thanks @sgrandh3 for taking a look at this.

[bunkerskyi]

@jrchamp Hello. I see more information needed badge on this issue. Please let me know if I can provide any additional info to speed up the process. We are very interested in solving this problem

[jrchamp]

Thanks @bunkerskyi! I'm not sure exactly which part is not working, so it would be very useful for us to understand where it is breaking. Any help you can provide would be significant:

1. Are you able to reproduce the issue yourself?
2. Specifically, can you install the Moodle mobile app and the Zoom mobile app and join a meeting that someone else creates in Moodle?
3. If so, does your name in the Zoom meeting show your Moodle user's name or does it show something else?
4. After the scheduled task that loads the data for the sessions report is complete, does the report have the name that showed in the meeting?
5. Which version of the mod_zoom plugin, Moodle Mobile app and Zoom mobile app are you using?

[sgrandh3]

When tested, by hosting a zoom meeting as an instructor, to a student who logged from only mobile (disconnected from the browser) , i got 2 records of the student. Did it multiple times, with the same result. Adding the session report for reference.
zoom_participants_94832982546.xlsx

[jrchamp]

I noticed the same "2 records" behavior when I was verifying the bug reported in #601. We need to take a look at the API response to see what's happening there and make sure that we're accurately representing the data in Moodle. It might be unintentionally duplicated or it might just be the way that Zoom reports non-host participants.