-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatal freeze at 1 second left in countdown of orphan subject located dialog #727
Comments
Finally got the transcript (Ftt2_3_24_2024_02_03_085248/radiolog_log_2024_02_03_085202.txt). The exact time of the reported freeze isn't known, but, the transcript does have a lot of tracebacks.
(the repeating four-line traceback repeats every second for the rest of the session; not clear if it caused any other issues) Note that the team name had multiple spaces when it was created 22 minutes prior:
seems to repeat every second, until this:
Note that this ending of the QLineEdit errors coincides with the begin of the z_Team101BackUp not in list errors. The list.remove(x): x not in list' message only happens once in the entire session. |
Creating a separate issue for the failure to delete team tab. |
Focusing on 'QLineEdit has been deleted' since the other issue has been moved to its own ticket #728: Note that there is a very stale message stack at the time - a training issue for sure, but, it shouldn't lead to errors:
Anyway - looking at the traceback, and adding the class names based on line number:
In other words: the countdown within sublectLocatedDialog is getting called, but, its parent newEntryWidget has been deleted. So the question is: how did the newEntryWidget get deleted? This line is in the transcript just beforehand:
And there are several similar lines above - again, probably a training issue but looks like these were (mostly) handled gracefully. The full transcript from 100843:
The last line - exception during GET - is interesting - wonder if it's related? On five of the 'closing unused new entry widget' occurrences, there is a note of closing the related CCD - should there be something similar for subject located or for clue? Actually, if one of those is open, the NEW shouldn't be deleted at all... right?
The first occurrence of 'looks like a clue' was not until hours later, so the subect located dialog must have been raised another means:
Looks like there were two subject located dialogs opened for Team 101 at the same time, and one of them was closed:
the next mention of 'subject located' was 101154, after the errors began. This might be something to try: two subject located dialogs open at the same time for the same callsign, then canceling one of them. |
Duplicated the hang at 1 second left! The countdown in question is in an orphan subject located dialog. When it gets to 1, the spinner shows up and radiolog freezes. How did the SLD become an orphan? Its parent NEW was deleted by clicking cancel in the NEW - which shouldn't be possible, but if there are two SLDs open for the same NEW, then apparently the NEW can be canceled after one of the SLDs is canceled. If all of the NEW's spawned SLDs are open when you try to cancel the NEW, then this dialog shows as expected: But if you open two SLDs from the same NEW, then cancel one of the SLDs, you can then cancel the NEW and the orphan SLD remains. Putting text in any field of that orphan SLD starts the countdown in question. Side note, should also be fixed: if you cancel both SLDs, these errors start showing, once per second:
Reconfirmed that the countdown does work as expected when the SLD's parent is open. This is true for each open SLD, i.e. for multiple simultaneous SLDs owned by the same NEW. This confirms that the orphan is the problem. |
Now that the cause is isolated, seems like this could be changed to low priority since it's pretty obscure, and definitely a training issue. But, best to leave it as medium priority since it actually causes a fatal freeze. |
Actually the LLAC wording was my fault: there is no countdown in LLAC - the only dialog with a coundown is the subject located dialog, which is the one that I sent a screenshot of to the reporter, and she confirmed that was the one. So - no need to check anything else - the orphan SLD is the problem. |
Proposed fixes:
|
Trying again the next day: I can't duplicate the freeze and spinner and countdown 1, but, I can duplicate the begin of QLineEdit tracebacks at the same time as the countdown expiration in the orphan SLD. Interesting.. but, the solution should take care of both symptoms. |
Reported at snow training 2/2/24. Need to get logs from R5.
The text was updated successfully, but these errors were encountered: