Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS "KMS Keys Allow Cross-Account Access" triggers on unique IDs #1665

Open
rdegraaf-ncc3 opened this issue Aug 28, 2024 · 0 comments
Open
Labels
bug Something isn't working potential Unconfirmed issue

Comments

@rdegraaf-ncc3
Copy link
Contributor

rdegraaf-ncc3 commented Aug 28, 2024

Describe the bug

The AWS finding "KMS Keys Allow Cross-Account Access" seems to trigger on KMS key policies that grant permissions to unique IDs (AROA..., etc.) rather than to accounts or ARNs. This is still an issue that should be reported, but perhaps it should be a separate issue: there is no convenient way to identify the account holding the principal identified by a unique ID, so it's not clear whether the permission is granted to another account or not. Also, AWS sometimes replaces principal ARNs in permission policies with unique IDs when those principals are deleted (https://repost.aws/knowledge-center/iam-resource-policy-format).

I suggest that this finding should be split into two:

  • One for the case where permissions are unambiguously being granted to another account.
  • One for the case where permissions are being granted to a unique ID that cannot be identified.

The same would hold for any related issues with resource-based permission policies.

@rdegraaf-ncc3 rdegraaf-ncc3 added bug Something isn't working potential Unconfirmed issue labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working potential Unconfirmed issue
Projects
None yet
Development

No branches or pull requests

1 participant