Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compile to service_slim and pub-sub pattern #9

Closed

Conversation

alfonsogarciacaro
Copy link

Changes discussed in the following PRs:

Strange, I thought I had the same commits from dotnet/fsharp in my fork than in yours @ncave, but maybe I rebased it again later. In any case, the only commit that matters is the last one, so you can cherry-pick it if you prefer 👍

KevinRansom and others added 26 commits November 15, 2021 17:17
* add debug emit docs

* add debug emit docs

* add debug emit docs

* add debug emit docs

* add debug emit docs

* add debug emit docs

* add debug emit docs
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Vlad Zarytovskii <[email protected]>
* fix non-nested mutrec bindings

* fix non-nested mutrec bindings

* fix non-nested mutrec bindings

* fix non-nested mutrec bindings
* Add try and with keywords to SynExpr.TryWith.

* Add match and with keywords to SynExpr.Match.

* Add match and with keywords to SynExpr.MatchBang.

* Add with keyword to SynExpr.ObjExpr and SynInterfaceImpl.

* Add with keyword to SynTypeDefnKind.Augmentation.

* Add with keyword to SynMemberDefn.Interface.

* Add with keyword to SynTypeDefnSig and SynExceptionSig.

* Add with keyword to SynMemberDefn.AutoProperty.

* Add with keyword to SynValSig.

* Add with keyword to SynPat.LongId for SynMemberDefn.Member.

* Corrected FSharpCodeAnalysisExtensions.fs

* Fix failing unit tests.

* Revert some named pattern matches.
Renamed Range to range.
Add comment above PropertyKeyword.

* Correct failing type check tests.

* Renamed unused values in pattern match.
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ied (dotnet#12430)

* don't suppress tailcalls in pipeline debugging if tailcalls are on

* don't suppress tailcalls in pipeline debugging if tailcalls are on
… Build ID 1481545 (dotnet#12435)

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1480996

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1480996

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1481545

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1481545

Co-authored-by: Kevin Ransom (msft) <[email protected]>
)

This renames the `projectFileName` field and `FileName` property to reflect the
actual use: the project's output file. This was unclear based on docs, but clear based on usage,
and so docs were added to help ensure correct usage.
* Added CI job for deterministic builds

* Attempt to fix deterministic checks

* Turn off rebuild

* Update test-determinism.ps1

Co-authored-by: Vlad Zarytovskii <[email protected]>
@ncave
Copy link
Owner

ncave commented Dec 28, 2021

@alfonsogarciacaro I cherry-picked your commit as you suggested, so closing this PR.

Sounds like a great improvement, thank you!
Some minor comments:

  • Technically you don't need to pass in a subscriber callback if you process files one by one by always passing lastFile to checker.ParseAndCheckProject. But it's fine, it works either way.
  • Perhaps you can rebase/rebranch from my fork just so that we're on the same page and don't need to cherry-pick.

@ncave ncave closed this Dec 28, 2021
@alfonsogarciacaro
Copy link
Author

Ah, you're right! For some reason I didn't think of that possibility 😅 There would be some overhead as we have to hit the cache many more times (and maybe some more extra work to initialize and create the project results). Probably it won't be noticeable but if you're ok with the callback, we can leave it as is for now 👍 I will rebranch from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants