Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid record type: SSHFP #6

Closed
KizzyCode opened this issue Mar 12, 2023 · 3 comments · Fixed by #8
Closed

Invalid record type: SSHFP #6

KizzyCode opened this issue Mar 12, 2023 · 3 comments · Fixed by #8
Assignees
@nbuchwitz
Labels
enhancement New feature or request

Comments

@KizzyCode
Copy link

Apparently, the DNSRecord-class does not support SSHFP records, which are (now?) supported by netcup.
@nbuchwitz
Copy link
Owner

From a first glance it should be enough to extend the list in https://github.com/nbuchwitz/nc_dnsapi/blob/master/nc_dnsapi/__init__.py#L25. PR welcome :-)

@nbuchwitz nbuchwitz mentioned this issue Mar 12, 2023
Merged
@nbuchwitz
Copy link
Owner

I was fixes another thing and added the support while at it. Please check if #8 works for you.

@nbuchwitz nbuchwitz self-assigned this Mar 12, 2023
@nbuchwitz nbuchwitz added the enhancement New feature or request label Mar 12, 2023
@KizzyCode
Copy link
Author

Yes; I actually did the same yesterday by hotpatching the installed package (I needed it for ansible) and as far as I can tell, this works perfectly 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbuchwitz nbuchwitz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for SSHFP record type nbuchwitz/nc_dnsapi
2 participants
@nbuchwitz @KizzyCode