Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider prepending '=' to install version when no character provided #101

Open
nbigaouette opened this issue Dec 10, 2019 · 1 comment
Open
Labels
enhancement New feature or request
Milestone

Comments

@nbigaouette
Copy link
Owner

As reported in #100, confusion can happen when a version to install is written without any leading character.

For example:

pycors install 3.8.0

will be interpreted as ^3.8.0 by the semver crate. This will in turn attempt to install a version matching >=3.8.0,<4.0.0, which at the current time matches 3.9.0.

While "valid" according to semver, it's probably not what the user expected.

Prepending a = in front of a requested install when no character is present should be considered. The downside of this is that the string provided is not strictly semver anymore.

@nbigaouette
Copy link
Owner Author

Some usefull notes regarding semantic versioning:

https://stackoverflow.com/questions/54720072/dependency-version-syntax-for-python-poetry

@nbigaouette nbigaouette added this to the 1.0 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant