Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design deployment is Active even if the Design Job failed #170

Closed
gertzakis opened this issue Jun 12, 2024 · 2 comments
Closed

Design deployment is Active even if the Design Job failed #170

gertzakis opened this issue Jun 12, 2024 · 2 comments
Assignees
@chadell
Labels
type: bug

Comments

@gertzakis
Copy link
Contributor

Environment

  • Python version: 3.11
  • Nautobot version: 1.6.23
  • nautobot-design-builder version: 1.3.0

Expected Behavior

When I run a Design Job and it fails, I expected the Design Deployment status to be something similar.

Observed Behavior

The Design Deployment status shown as Active.

Steps to Reproduce

  1. Run a Design Job that it fails
  2. Go to Design Deployments and check that deployment
@gertzakis gertzakis changed the title Design deployment is Active when if the Design Job failed Design deployment is Active even if the Design Job failed Jun 12, 2024
@chadell chadell self-assigned this Jun 13, 2024
@chadell
Copy link
Contributor

chadell commented Jun 13, 2024

The idea is that a failed Design Deployment should not even be created as a DesignDeployment

@chadell chadell mentioned this issue Jun 13, 2024
Merged
@chadell
Copy link
Contributor

chadell commented Jun 14, 2024

fixed in #172

@chadell chadell closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadell chadell

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gertzakis @chadell