Feature requests (old)

[naugtur]

Request features here. Explanations as to why it'd be useful very welcome 😉

This was converted from an issue so it's a bit messy

[CADBOT]

The ability to specify a different registry than the .npmrc file. Mine specifies a custom registry, but I'd still like to use the normal one when running audit-resolve and check.

[naugtur]

Should work with npms own flags

[naugtur]

@CADBOT interesting. This uses npm under the hood and it's intended (I started the process) as a future npm audit feature, so not sure where to go from here. I'll see if npm accepts a cli argument to override repo url, and I'll pass it through in that case. Got other thoughts?

[CADBOT]

There is a registry flag that can be used: npm run audit --registry https://registry.npmjs.org/ at which point the registry configured in the rc file is overridden.

[CADBOT]

Wrote up a quick PR that has a working example

[joh-klein]

Is there a chance to skip/ignore all DevDependencies? I know there is one for npm audit, but only when you do npm audit fix

[naugtur]

currently you can ignore low severity automatically, but not dev dependencies.
I didn't put that in because with the data I get as input, I wasn't sure what would happen if something is both in deps and devDeps

I'd consider adding this as an option defined in the audit-resolve file. How would you want to ignore them? In resolve-audit or in check-audit, or both?

[joh-klein]

I thought both, to be honest. And why not do it as an cli argument?

[naugtur]

audit-resolve file is where this tool puts your decisions about what's safe to ignore etc. so it made sense to me to keep it there. Any reasons skipping dev dependencies should be treated as unrelated? Should a run with dev and without dev share the same audit-resolve file in your opinion? I'm not sure if I see a situation where that'd be useful, but happy to get feedback!

[stewartduffy]

Any chance for an option for longer remind timeframe. 24 hours can be difficult to deal with. Propose

• Remind 24 hours
• Remind 1 week
• Remind 1 month

[naugtur]

Public announcement: Remind option will not change, but I'm planning to add expiry to ignore.

[naugtur]

@stewartduffy npm-audit-resolver@next supports expiring ignores, which effectively does what you wanted.

[Undistraction]

FWIW I definitely like the idea of being able to ignore all advisories for dev dependencies. How about allowing certain packages to be ignored? Guess you have the same problem again of how to handle advisories that apply both to ignored packages and not-ignored packages.

[stewartduffy]

Hey @naugtur sorry I dropped out of this conversation for ages - I got pulled on a number of different projects and got busy. I will update out app to use npm-audit-resolver@next today and give feedback on how we go. Thanks for this! Sounds like it will do just the trick.

[stewartduffy]

@naugtur I just tried it with the expiring ignore for 1 month. Works well thanks!

[jansu76]

Suggestion: possibility to have check-audit fail only if some high or critical issues were found. Not when there there were low issues.

Basically a --ignoreLow parameter for check-audit, would do what I am after. (by the way, I did not get resolve-audit --ignoreLow to work. It claimed ✔ automatically ignore low severity issue, but ignores did not appear in audit-resolve.json)

Reasoning: we currently ignore all low severity vulnerabilities. We have e.g. a dev dependency @vue/cli-plugin-unit-jest that has a lot (tens) of low severity issues. Having all those issues configured in audit-resolve.json makes the configuration file very noisy. Especially since there is no way to see which entry ignores a low issue and which entry ignores a critical issue.

Having an audit-resolve.json that contains many low severity issues makes people not care about it, and not care about changing it, so much. If it contained only serious issues, changing it would be a thing that requires careful consideration.

Kind of a duplicate of the earlier request about ignoring devDependencies. I think that also for that use case it might be better to keep dev dependencies out of audit-resolve.json, and instead add the ability to limit checking in check-audit to ignore alerts from dev dependencies.

 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runtime>jest-snapshot>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-snapshot>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-runtime>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runtime>jest-message-util>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-config>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-config>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-runtime>jest-config>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runtime>jest-config>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-haste-map>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-haste-map>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-runtime>jest-haste-map>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runtime>jest-haste-map>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runner>jest-runtime>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>jest-runtime>micromatch>braces
 -  devDependencies: @vue/cli-plugin-unit-jest>jest>jest-cli>micromatch>braces
--------------------------------------------------
 😱   Unresolved issues found!

[naugtur]

@coreysnyder that's definitely interesting.
For now I believe you can only use symlinks.

But there's a few ways to solve this. Let's pop out to an issue just for this and discuss. Please open the issue on the audit-resolver-core repo.

I'd like to think about ways we could reference other files with rules.
One difficulty is paths differ between installation so if depth of sub dependency differs, decision from resolve file doesn't apply.

We'll discuss more in the issue.

Thanks for bringing this up!

[ghost]

Feature request: calling "audit-resolve" (or "audit-resolve --clean") removes decisions from the json that are no longer relevant. Example After an "npm audit fix" i want to see the whitelist get shorter, i do not want to update all decision timestamps, which happens if i empty the file and call audit-resolve again.

[naugtur]

@ion2s-JM I can relate. Good idea. Please create a separate issue where we could discuss details.
I'd suggest a PR too, but it might require changes to audit-resolver-core as well. let's talk more in the issue.

[jmac105]

Feature request: Make 'resolve-audit' exit with a non-zero exit code if it is run from a CI server, potentially by using https://www.npmjs.com/package/is-ci or similar.

I've noticed that if a CI server is incorrectly setup to call 'resolve-audit' rather than 'check-audit', then it will exit with a 0 exit code regardless of whether or not there vulnerabilities that needed to be addressed. This means the audit will appear to pass.

I can't think of any use case where you would deliberately run 'resolve-audit' from a Ci server. Happy to try raising a PR for this if you give the go ahead.

[naugtur]

@jmac105 interesting idea. Instead of pulling in a new dependency, I'd rather exit(1) every time. What do you think?

[jmac105]

Potentially, looking again at the output from the CI server I wonder if there's an exit condition check that could be added somewhere? I'm interested to know what's causing it to exit here and no just hang waiting for input that will never come?

[13:34:38]	Step 3/10: NPM Audit (Node.js NPM) (7s)
[13:34:38]	[Step 3/10] Executing npm via wrapping shell script
[13:34:38]	[Step 3/10] Starting: /data/teamcity-agent/temp/agentTmp/wrapper53360257518953549.sh run audit
[13:34:38]	[Step 3/10] in directory: /data/teamcity-agent/work/34ba38c1bb7b80/sourceCode
[13:34:38]	[Step 3/10] npm run audit (7s)
[13:34:38]	[npm run audit] 
[13:34:38]	[npm run audit] > [email protected] audit /data/teamcity-agent/work/34ba38c1bb7b80/sourceCode
[13:34:38]	[npm run audit] > resolve-audit
[13:34:38]	[npm run audit] 
[13:34:38]	[npm run audit] >>>> npm audit --json 
[13:34:45]	[npm run audit] >>>> exit: 1
[13:34:45]	[npm run audit] 
[13:34:45]	[npm run audit] --------------------------------------------------
[13:34:45]	[npm run audit]  minimist needs your attention.
[13:34:45]	[npm run audit] 
[13:34:45]	[npm run audit] [ moderate ] Prototype Pollution
[13:34:45]	[npm run audit]  vulnerable versions <1.2.3 found in:
[13:34:45]	[npm run audit]  - dependencies: another-internal-package>etl>csv-parser>minimist
[13:34:45]	[npm run audit]  - dependencies: etl>csv-parser>minimist
[13:34:45]	[npm run audit] _
[13:34:45]	[npm run audit]  d) show more details and ask me again
[13:34:45]	[npm run audit]  r) remind me in 24h
[13:34:45]	[npm run audit]  i) ignore paths
[13:34:45]	[npm run audit]  del) Remove all listed dependency paths
[13:34:45]	[npm run audit]  s) Skip this
[13:34:45]	[npm run audit]  q) Quit
[13:34:45]	[npm run audit] What would you like to do? 
[13:34:45]	[Step 3/10] Process exited with code 0

If I run resolve-audit locally and ctrl-c out of it when it prompts me for input it recognises that and exits with code 2, hard to replicate the behaviour seen on the ci server

[naugtur]

please move to a separate issue and we can discuss in more detail there

[zcabjro]

Small but nice usability improvement would be to use a human-readable date for expires. Would make reviewing audit-resolve.json easier for team members that would otherwise have to verify or trust that the epoch time is both desirable and correct.

[Undistraction]

Yarn now offers a --groups flag which allows you to choose not to audit development dependencies. It would be really helpful if this could be supported.

https://classic.yarnpkg.com/en/docs/cli/audit/

[naugtur]

@Undistraction all flags you set on check-audit are passed down to yarn (except for the yarn flag itself :) )

[Undistraction]

@naugtur Ah! Amazing. Thank you.

[emilong]

I'd love to be able to add a comment about why I chose to ignore a warning for both myself and teammates who might wonder about it in the future. :)

[naugtur]

@emilong That's one of the oldest pending features. I think I added the reason field to the JSON schema already, but didn't come up with a good idea how to take the input without making the process longer for ppeople not using it.

[drswobodziczka]

Hello @naugtur !

It would be nice to have the resolver just to forward exit status received from npm-audit.

Namely suppose the following npm script:

"security:check": "node node_modules/npm-audit-resolver/check.js --audit-level=high"

^ it just fails for any not yet resolved issue (however logs exit(0) status from npm audit). I would rather expect it to log all the lower_than_high ones -- but PASS in the same time, respecting params given to npm-audit.

[naugtur]

The whole point of check-audit is to only return 0 when npm audit returns positive. What exactly would it do in all cases? When something is found, when something should be ignored etc.

Want to work on listing a sort of user story with all permutations?