Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by.roi argument in neuprint_connection_table broken -- still returns broken down connections #69

Closed
markuspleijzier opened this issue Feb 4, 2020 · 3 comments

Comments

@markuspleijzier
Copy link

Example:

mbon_df <- neuprint_connection_table(799586652, prepost = "POST", by.roi = FALSE)
mbon_df

@alexanderbates
Copy link
Collaborator

Hey Markus! Sorry not sure what's happening there. This line of code works for me... do you have an up-to-date install? What is returned? I get 941 (all unique) postsynaptic partners for this neuron and no roi field.

@jefferis
Copy link
Contributor

jefferis commented Feb 4, 2020

Works for me as well.

> mbon_df
       bodyid    partner prepost weight
1   799586652 5813022234       1    465
2   799586652 5901213440       1    312
3   799586652  667857582       1    257
4   799586652  424767514       1    197

Perhaps @alexanderbates is right that your install may be out of date.

@jefferis
Copy link
Contributor

jefferis commented Feb 5, 2020

@markuspleijzier can you close if this works for you now? Note that I pushed a small fix to ensure that by.roi is always correctly handled when progress=TRUE (see #70) but that wouldn't have been relevant for the example code you gave in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants