Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom decoration on Half Class Table disappears when table is short. #2207

Closed
calculuschild opened this issue Jun 7, 2022 · 2 comments · Fixed by #2211
Closed

Bottom decoration on Half Class Table disappears when table is short. #2207

calculuschild opened this issue Jun 7, 2022 · 2 comments · Fixed by #2211
Labels
bug We say this works but it doesn't P3 - low priority Obscure tweak or fix for a single user phb-style

Comments

@calculuschild
Copy link
Member

See https://www.reddit.com/r/homebrewery/comments/v63m5f/comment/ibj6mv6/?utm_source=share&utm_medium=web2x&context=3

The bottom decoration probably gets nudged out when it starts to overlap the top one.

@calculuschild calculuschild added bug We say this works but it doesn't phb-style P3 - low priority Obscure tweak or fix for a single user labels Jun 7, 2022
@Gazook89
Copy link
Collaborator

Gazook89 commented Jun 8, 2022

Not every class table in the PHB has the exact same positioning of that ring, though, right? If that's right, I don't think this is much of an issue. More ideally the decoration would be randomly placed at some point around the table, but obviously CSS won't do that, so HB just places them where it does.

Maybe i'm wrong about my initial assumption though.

@calculuschild
Copy link
Member Author

calculuschild commented Jun 8, 2022

The problem isn't the positioning, but that there should be two decorations, one at the top and one at the bottom. When the table is too short, the bottom decoration doesn't appear at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't P3 - low priority Obscure tweak or fix for a single user phb-style
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants