Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty column 1 collapses, column 2 gets shifty #1566

Closed
ericscheid opened this issue Aug 13, 2021 · 3 comments
Closed

Empty column 1 collapses, column 2 gets shifty #1566

ericscheid opened this issue Aug 13, 2021 · 3 comments
Labels
bug We say this works but it doesn't

Comments

@ericscheid
Copy link
Collaborator

This only happens with the v3 renderer, not the legacy renderer (using legacy column breakers).

# Column calumny

\column

## column two??

Sed enim risus, congue non, tristique in, commodo eu, metus. Aenean tortor mi, imperdiet id, gravida eu, posuere eu, felis. Mauris sollicitudin, turpis in hendrerit sodales, lectus ipsum pellentesque ligula, sit amet scelerisque urna nibh ut arcu. Aliquam in lacus. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Nulla placerat aliquam wisi. Mauris viverra odio. Quisque fermentum pulvinar odio. Proin posuere est vitae ligula. Etiam euismod. Cras a eros.

:

Nulla facilisi. In vel sem. Morbi id urna in diam dignissim feugiat. Proin molestie tortor eu velit. Aliquam erat volutpat. Nullam ultrices, diam tempus vulputate egestas, eros pede varius leo, sed imperdiet lectus est ornare odio. Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Proin consectetuer velit in dui. Phasellus wisi purus, interdum vitae, rutrum accumsan, viverra in, velit. 

image

@ericscheid ericscheid added bug We say this works but it doesn't ✅ Added to V3 labels Aug 13, 2021
@Gazook89
Copy link
Collaborator

This doesn't fix the actual issue, but a quick workaround is:

# Column Calamity
:

\column

Here is some text in the second column.

@AlexeySachkov
Copy link
Member

Observation 1: a block with zero height doesn't trigger a column break. legacy renderer/syntax inserts a <pre><code></code></pre> elements, which take almost 12px:

image

If I set height of .columnSplit (which is zero by default) to at least 1px, it starts to work, but in an unexpected way:

image

If I further disable break-before it works as expected:
image

I've tried to read about break-after and break-before properties, but still have no idea why it behaves this way

break-before was added by @calculuschild in #1184

@Gazook89
Copy link
Collaborator

I think this is resolved at some point-- the property is now break-after rather than -before. And I can't reproduce this. Possibly it was the columnWrapper that did it? I don't see it in the DOM in the screenshot above.

I'm going to close this-- please reopen if i'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't
Projects
None yet
Development

No branches or pull requests

3 participants