From 18a60d6f7f84c2774c29cb926fe421df2deb5bc0 Mon Sep 17 00:00:00 2001
From: Alberto Ricart <alberto@synadia.com>
Date: Tue, 17 Sep 2024 10:32:41 -0500
Subject: [PATCH] [CHANGE] removing a tag that doesn't exist results in an
 error (#228)

---
 v2/types.go      |  5 ++++-
 v2/types_test.go | 27 +++++++++++++++++----------
 2 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/v2/types.go b/v2/types.go
index f004cdf..f0049ab 100644
--- a/v2/types.go
+++ b/v2/types.go
@@ -465,15 +465,18 @@ func (u *TagList) Add(p ...string) {
 }
 
 // Remove removes 1 or more tags from a list
-func (u *TagList) Remove(p ...string) {
+func (u *TagList) Remove(p ...string) error {
 	for _, v := range p {
 		v = strings.TrimSpace(v)
 		idx := u.find(v)
 		if idx != -1 {
 			a := *u
 			*u = append(a[:idx], a[idx+1:]...)
+		} else {
+			return fmt.Errorf("unable to remove tag: %q - not found", v)
 		}
 	}
+	return nil
 }
 
 type CIDRList []string
diff --git a/v2/types_test.go b/v2/types_test.go
index d4eb7e5..9d8a205 100644
--- a/v2/types_test.go
+++ b/v2/types_test.go
@@ -126,7 +126,10 @@ func TestTagList(t *testing.T) {
 	AssertEquals(true, tags.Contains("TWO"), t)
 	AssertEquals("TWO", tags[1], t)
 
-	tags.Remove("ONE")
+	err := tags.Remove("ONE")
+	if err == nil {
+		t.Fatal("removing tag that doesn't exist should have failed")
+	}
 	AssertEquals("one", tags[0], t)
 	AssertEquals(true, tags.Contains("TWO"), t)
 }
@@ -476,23 +479,27 @@ func TestTagList_Add(t *testing.T) {
 
 func TestTagList_Delete(t *testing.T) {
 	type test struct {
-		v        string
-		a        TagList
-		shouldBe TagList
+		v          string
+		a          TagList
+		shouldBe   TagList
+		shouldFail bool
 	}
 
 	tests := []test{
-		{v: "A", a: TagList{}, shouldBe: TagList{}},
+		{v: "A", a: TagList{}, shouldBe: TagList{}, shouldFail: true},
 		{v: "A", a: TagList{"A"}, shouldBe: TagList{}},
-		{v: "a", a: TagList{"A"}, shouldBe: TagList{"A"}},
-		{v: "a:Hello", a: TagList{"a:hello"}, shouldBe: TagList{"a:hello"}},
-		{v: "a:a", a: TagList{"a:A"}, shouldBe: TagList{"a:A"}},
+		{v: "a", a: TagList{"A"}, shouldBe: TagList{"A"}, shouldFail: true},
+		{v: "a:Hello", a: TagList{"a:hello"}, shouldBe: TagList{"a:hello"}, shouldFail: true},
+		{v: "a:a", a: TagList{"a:A"}, shouldBe: TagList{"a:A"}, shouldFail: true},
 	}
 
 	for idx, test := range tests {
-		test.a.Remove(test.v)
+		err := test.a.Remove(test.v)
+		if test.shouldFail && err == nil {
+			t.Fatalf("[%d] expected delete to fail: %v", idx, test.a)
+		}
 		if !test.a.Equals(&test.shouldBe) {
-			t.Errorf("[%d] expected lists to be equal: %v", idx, test.a)
+			t.Fatalf("[%d] expected lists to be equal: %v", idx, test.a)
 		}
 	}
 }