Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getIp dies #5

Open
mzedeler opened this issue May 18, 2022 · 3 comments
Open

getIp dies #5

mzedeler opened this issue May 18, 2022 · 3 comments

Comments

@mzedeler
Copy link

When I run esbuild serve with the -w parameter, it dies with this error:

11:55 $ node esbuild.config.mjs -w
[watch] build finished, watching for changes...

Serving πŸ›

Local β†’ http://localhost:3000

file:///home/mike/workspace/teamway-test/node_modules/create-serve/src/utils/getIp.js:6
		.find(ip => ip.family == 'IPv4' && !ip.internal).address;
		                                                ^

It seems that there is some assumption in getIp that doesn't hold (ip.family is numeric on my machine).

Node vesion: 18.
Ubuntu version: 22.

@mzedeler
Copy link
Author

It looks like a bug, because according to the documentation, networkInterfaces only returns numeric 4 or 6. I can provide a PR to fix it.

@pask2
Copy link

pask2 commented Jun 4, 2022

Hi, I'm having this issue currently. @mzedeler did you have a good fix? If so, could you put up a PR?

@pask2
Copy link

pask2 commented Jun 7, 2022

Actually, this looks like an issue in nativew/serve. Also here is the issue/PR that resolves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants