Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Vendor support #33

Open
dwlnetnl opened this issue Aug 12, 2016 · 2 comments
Open

Vendor support #33

dwlnetnl opened this issue Aug 12, 2016 · 2 comments

Comments

@dwlnetnl
Copy link

In Go 1.6 the GO15VENDOREXPERIMENT environment variable is internally set to 1. But the code checks explicitly for the variable.

Aside from the detection, there is also the watching of the vendor directory tree. I think we can ignore this directory if the vendoring experiment is enabled. This reduces the open file count which is a good thing for macOS.

Any thoughts? No problem to prepare a PR.

@nathany
Copy link
Owner

nathany commented Aug 12, 2016

Thanks for bringing this up. GO15VENDOREXPERIMENT is going away completely in the imminent release of Go 1.7, which means Looper shouldn't be looking for that environment variable at all.

Given that fsnotify is still using kqueue on macOS, it may make sense to stop watching vendor/ for now. Though once we have FSEvents, I think it might be fine to watch vendor for changes but still exclude it when running all the tests.

@nathany
Copy link
Owner

nathany commented Aug 12, 2016

I need to give Looper some ❤️ sometime. There are a few things I want to improve, not just this.

Don't worry about a PR. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants