-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install notes for readme #87
Comments
To be honest, it might be worth adding a step to the config flow. "Migrating from....? Read these docs first" with a link. |
Yep seems a shame to divert attention from the actual core install process, these are ‘before you install steps’ - so maybe a wiki or something similar |
Yeah, but it's our last chance to stop someone before they create duplicate sensors by accident (if they haven't read the readme yet). Alternatively, we can rename ours so the don't conflict, but that does make migrating a bit harder... |
We could add a background step to check a cross section of existing sensors to ensure they don't still exist and alert if they do? Therefore if the migration steps have been followed the user sees nothing, if not we can end the config flow and redirect to the wiki/readme? I'll have some time mid-week so will look at re-jigging the config flow as per our discussions @canton7 (TCP/UDP/LAN etc) and see if I can squeeze something like this in. |
Yep, that sounds like a better plan! |
After switching over from HA-FoxESS-Modbus, I found it reasonably straightforward. I do have a few extra sensors, but for the most part this worked as a high-level approach:
@FozzieUK 's advice works well, I second having that as a line / collapsed section in the Readme would be useful. |
@FozzieUK done, does that look OK? |
@nathanmarlor looks good to me thanks 👍 |
It may be helpful to add a few notes to the Readme for people moving to this integration from the StealthChestnut version as there are a number of similar problems occurring. Hopefully adding some notes to do things in a certain order, and remove certain sensors that can be duplicated would help to avoid this.
I suspect this might be a moving target for a while but starting with the most common ones.
The text was updated successfully, but these errors were encountered: