Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #537, commit and format check doesn't execute when PR title format fails #516

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

paulober
Copy link
Contributor

Fixes #537 with continue-on-error solution.

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • The action continues even if title format check failes

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Personal

@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch 2 times, most recently from 8d57065 to ad9c61c Compare June 24, 2022 13:57
@paulober paulober changed the title Fix nasa/cFE#2112 Fix nasa/cFE#2112, commit and format check doesn't execute when PR title format fails Jun 24, 2022
@skliper skliper mentioned this pull request Jun 24, 2022
2 tasks
@astrogeco
Copy link
Contributor

@paulober does this still show a failed check for the commit and title job?

@astrogeco astrogeco added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 13, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Jul 13, 2022

CCB 7/13/2022: Dylan will check cFS to see if there is a duplicate. If not, move issue to cFS/amend commit. Follow up on Gerardo's question above.

@dzbaker dzbaker removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 13, 2022
@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch from 49954d9 to 5764df6 Compare July 13, 2022 20:06
@paulober
Copy link
Contributor Author

@paulober does this still show a failed check for the commit and title job?

good that you mentioned that. "continue-on-error" would not mark the workflow as failed no matter what the step results. So I replaced the "continue-on-error" solution with, so to speak, "run-if", which runs the second step ("check commit message") even if the first step threw an error. This solution now lets the job fail if one of the two steps fails but still it always runs both.

@paulober paulober changed the title Fix nasa/cFE#2112, commit and format check doesn't execute when PR title format fails Fix #517, commit and format check doesn't execute when PR title format fails Jul 13, 2022
@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch from 5764df6 to 386a428 Compare July 13, 2022 20:14
@dzbaker dzbaker changed the title Fix #517, commit and format check doesn't execute when PR title format fails Fix #537, commit and format check doesn't execute when PR title format fails Aug 5, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Sep 1, 2022

@paulober I moved the issue to cFS, now it's #537. Would you be able to amend the commit message to reference the new issue number?

@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch from 386a428 to d996ecf Compare September 2, 2022 14:45
@paulober
Copy link
Contributor Author

paulober commented Sep 2, 2022

@paulober I moved the issue to cFS, now it's #537. Would you be able to amend the commit message to reference the new issue number?

Done

@dzbaker dzbaker added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 2, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Sep 8, 2022

CCB 8 September 2022: Need to update commit message to indicate that it is fixing the format check for CI.

@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch from d996ecf to 44f9833 Compare September 8, 2022 21:25
Switched continue on error with an run step if
@paulober paulober force-pushed the fix-2112-cFE-format-check-error branch from 44f9833 to 4b65321 Compare September 8, 2022 21:28
@paulober
Copy link
Contributor Author

paulober commented Sep 8, 2022

CCB 8 September 2022: Need to update commit message to indicate that it is fixing the format check for CI.

Done and rebased feature branch.

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 15, 2022
@dzbaker dzbaker merged commit 44a9afd into nasa:main Sep 16, 2022
@paulober paulober deleted the fix-2112-cFE-format-check-error branch September 16, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit and format check doesn't execute when PR title format fails
5 participants