-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #537, commit and format check doesn't execute when PR title format fails #516
Conversation
8d57065
to
ad9c61c
Compare
@paulober does this still show a failed check for the commit and title job? |
CCB 7/13/2022: Dylan will check cFS to see if there is a duplicate. If not, move issue to cFS/amend commit. Follow up on Gerardo's question above. |
49954d9
to
5764df6
Compare
good that you mentioned that. "continue-on-error" would not mark the workflow as failed no matter what the step results. So I replaced the "continue-on-error" solution with, so to speak, "run-if", which runs the second step ("check commit message") even if the first step threw an error. This solution now lets the job fail if one of the two steps fails but still it always runs both. |
5764df6
to
386a428
Compare
386a428
to
d996ecf
Compare
CCB 8 September 2022: Need to update commit message to indicate that it is fixing the format check for CI. |
d996ecf
to
44f9833
Compare
Switched continue on error with an run step if
44f9833
to
4b65321
Compare
Done and rebased feature branch. |
Fixes #537 with continue-on-error solution.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Personal