Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete conversion of CFE_SB_MsgId_t in test_cfe_msg_msgid_v2.c #2060

Open
plexilcrf opened this issue Feb 24, 2022 · 1 comment
Open

Comments

@plexilcrf
Copy link

Describe the bug
Building the cFE unit tests with MISSION_INCLUDE_CCSDSEXT_HEADER and MISSION_MSGID_V2 set to TRUE fails due to compiler errors in modules/msg/ut-coverage/test_cfe_msg_msgid_v2.c. The errors are due to calling CFE_MSG_SetMsgId() with a "message ID" parameter which is an integer, not a CFE_SB_MsgId_t.

To Reproduce
Steps to reproduce the behavior:

  1. Configure the sample mission with MISSION_INCLUDE_CCSDSEXT_HEADER and MISSION_MSGID_V2 set to TRUE.
  2. Attempt to build the unit tests. Note compiler errors.

Expected behavior
The unit tests should compile without error.

Code snips
See attached patch.
test_cfe_msg_msgid_v2_patch.txt

System observed on:

  • "Hardware": Generic x86-64 PC VM on VirtualBox 6.1.30, running on macOS 11.6.3.
  • OS: Ubuntu 20.04.4
  • Compiler: gcc 9.3.0
  • Versions: Current head of cFE 'main' branch, OSAL v6.0.0-rc4, PSP v1.6.0-rc4

Additional context
Toolchain is configured to build 32-bit apps.

Reporter Info
Chuck Fry, QTS Inc., a subcontractor to KBR Wyle on ISRDS-3, NASA ARC Code TI
[email protected]

@skliper skliper added the bug label Mar 18, 2022
@skliper skliper added unit-test and removed bug labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants