Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59, remove unneeded stack object #60

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Dec 1, 2023

Checklist (Please check before submitting)

Describe the contribution
Remove the Initial dwell table object from MD_InitTableServices. This object was not actually used, and consumed several kB of stack space unnecessarily, depending on the size of the table.

Fixes #59

Testing performed
Run MD in sample config

Expected behavior changes
Peak stack use decreases by about 2kB (which is sizeof(MD_DwellTableLoad_t))

System(s) tested on
Debian

Additional context
This extra object made it more likely for MD to overrun its stack during startup vs other similar CFS apps. This was particularly the case where small stack sizes were used (e.g. 8kB).

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Remove the Initial dwell table object from MD_InitTableServices.
This object was not actually used, and consumed several kB of
stack space unnecessarily, depending on the size of the table.
@dzbaker dzbaker merged commit bbdca55 into nasa:main Dec 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dwell Table instantiated on stack, but not used
2 participants