Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #43, Refactor MAT table to be more portable #86

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix #43, Refactor MAT table to be more portable #86

merged 1 commit into from
Apr 11, 2023

Conversation

dmknutsen
Copy link
Contributor

@dmknutsen dmknutsen commented Apr 3, 2023 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution
The updated MAT table uses the CFE_MSG_CMD_HDR_INIT macro to make MAT commands header agnostic. Further this implementation makes the tables endian agnostic.

Fixes #43

Testing performed
Steps taken to test the contribution:

  1. Modified hs_monitors.c to print each table entry when the table gets read in by FSW.
  2. Ran a test to confirm that the expected commands/MIDs get read in when the table is validated.
  3. Ran a test to ensure that the expected commands get sent when the table is used/executed.

Expected behavior changes
None.

Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA Goddard

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2023
View reviewed changes
fsw/tables/hs_mat.c
(sizeof(HS_MATEntry_t) * HS_MAX_MSG_ACT_TYPES)};

/* Checksum for each desired command - Note that if checksum is enabled, real values (non-zero) must be input */
#ifndef CFE_TBL_NOOP_CKSUM

Check notice

Code scanning / CodeQL

Conditional compilation

Use of conditional compilation must be kept to a minimum.
fsw/tables/hs_mat.c Fixed Show fixed Hide fixed
@dmknutsen dmknutsen added this to the Equuleus milestone Apr 4, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 5, 2023
View reviewed changes
fsw/tables/hs_mat.c
#define CFE_TBL_NOOP_CKSUM 0x00
#endif

#ifndef CFE_ES_NOOP_CKSUM

Check notice

Code scanning / CodeQL

Conditional compilation

Use of conditional compilation must be kept to a minimum.
@dmknutsen dmknutsen requested a review from jphickey April 10, 2023 18:22
jphickey
jphickey approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dzbaker dzbaker merged commit 66efa2e into nasa:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:Approved Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Use CFE_MSG_CMD_HDR_INIT macro in Message Action Table implementation
3 participants
@dmknutsen @jphickey @dzbaker