Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default InputOffset in HK Copy Table Needs Update for New Tlm Hdr Size #40

Open
1 task done
keegan-moore opened this issue Feb 7, 2023 · 0 comments
Open
1 task done

Comments

@keegan-moore
Copy link

keegan-moore commented Feb 7, 2023

Checklist (Please check before submitting)

  • [z] I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
The default copy table looks at byte offset 12 of the cFE messages. The new Tlm secondary header padding for 64-bit alignment causes the start of data to be at 16 bytes into the packet.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Code snips
Currently:

    /*   0 */ {
        CFE_SB_MSGID_WRAP_VALUE(CFE_EVS_HK_TLM_MID),
        12,
        CFE_SB_MSGID_WRAP_VALUE(HK_COMBINED_PKT1_MID),
        12,
        4,
    },
    /*   1 */
    {
        CFE_SB_MSGID_WRAP_VALUE(CFE_TIME_HK_TLM_MID),
        12,
        CFE_SB_MSGID_WRAP_VALUE(HK_COMBINED_PKT1_MID),
        16,
        4,
    },
    /*   2 */
    {
        CFE_SB_MSGID_WRAP_VALUE(CFE_SB_HK_TLM_MID),
        12,
        CFE_SB_MSGID_WRAP_VALUE(HK_COMBINED_PKT1_MID),
        20,
        4,
    },
    /*   3 */
    {
        CFE_SB_MSGID_WRAP_VALUE(CFE_ES_HK_TLM_MID),
        12,
        CFE_SB_MSGID_WRAP_VALUE(HK_COMBINED_PKT1_MID),
        24,
        4,
    },
    /*   4 */
    {
        CFE_SB_MSGID_WRAP_VALUE(CFE_TBL_HK_TLM_MID),
        12,
        CFE_SB_MSGID_WRAP_VALUE(HK_COMBINED_PKT1_MID),
        28,
        4,
    },

The input offset for each should be 16, and the output offset should start at 16 (16, 20, 24, 28, 32).

System observed on:

  • Hardware: x64 (but should work for any)
  • OS: PC-Linux (but should work for any)
  • Versions cFE Draco rc4

Additional context

Additionally (optionally), the current table reads the first 4 bytes out of each packet. I think it would make more sense to only read the command count and command error count (the first 2 bytes) of each packet. If this also gets implemented, remember to update the numBytes accordingly.

Reporter Info
Keegan Moore
NASA/GSFC

@keegan-moore keegan-moore changed the title Default InputOffset in HK Copy Table Needs Update for New Tlm Default InputOffset in HK Copy Table Needs Update for New Tlm Hdr Size Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants