Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #120, address sanitizer issue in fm_dispatch unit test #121

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

avan989
Copy link

@avan989 avan989 commented Jun 20, 2024

fix #120, fix passing in null as parameter in unit test

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

Testing performed
Steps taken to test the contribution:
Add the following option:
add_compile_options(
-fsanitize=address
-fsanitize=undefined
-fsanitize-recover=all
-g
)
add_link_options(
-fsanitize=address
-fsanitize=undefined
-fsanitize-recover=all
)

Make SIMULATION=native ENABLE_UNIT_TESTS=true prep

make install

Run Test

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.
    Anh Van, GSFC

@dzbaker
Copy link
Contributor

dzbaker commented Jun 20, 2024

CCB 20 June 2024: Approved pending review by @jphickey.

Fix nasa#120, fix passing in null as parameter in unit test
@avan989 avan989 force-pushed the Fix-120-address-sanitizer-fm-dispatch branch from 2d2f1ac to 55bdfb0 Compare June 21, 2024 09:55
@avan989
Copy link
Author

avan989 commented Jun 21, 2024

updated to amend commit message. @dzbaker can you rerun the workflow?

@dzbaker
Copy link
Contributor

dzbaker commented Aug 8, 2024

CCB 8 August 2024: Approving at recommendation of @jphickey.

@dzbaker dzbaker merged commit d49bf9e into nasa:main Aug 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address Sanitizer issue in coverage-fm-fm_dispatch
3 participants