Fix #62, correct name match in table build #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirm that the next char in the name match is a separator before breaking out of the loop. This avoids matching on a prefix, such as SC to SCH_LAB.
jphickey
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Confirm that the next char in the name match is a separator before breaking out of the loop. This avoids matching on a prefix, such as SC to SCH_LAB.
Fixes #62
Testing performed
Build tables for SC and SCH_LAB in same project/mission
Expected behavior changes
Successful table build
System(s) tested on
Debian
Additional context
This only fixes the issue for app names that share a substring but not a whole word/term. For instance if using SCH and SCH_LAB together in the same mission, that will still be a problem. But that is unlikely to occur.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.