Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #199, Use CFE_MSG_PTR instead of &(x).Msg #421

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
No change.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I was about to do this myself, but then noticed the PR.

Only thing is that it needs a rebase, tlm_header is now TelemetryHeader ... etc.

@thnkslprpt
Copy link
Contributor Author

Thanks for doing this! I was about to do this myself, but then noticed the PR.

Only thing is that it needs a rebase, tlm_header is now TelemetryHeader ... etc.

Cool no worries Joe @jphickey.
Rebased etc. and seems fine now.
Cheers

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for submitting!

@jphickey jphickey added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:Approved labels Dec 13, 2023
@dmknutsen dmknutsen removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Dec 15, 2023
@dmknutsen dmknutsen merged commit 27f7532 into nasa:main Dec 15, 2023
17 checks passed
@thnkslprpt thnkslprpt deleted the fix-199-use-CFE_MSG_PTR-macro branch December 15, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CFE_MSG_PTR instead of &(x).Msg
3 participants