-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add linkedQueryParam implementation, tests and docs #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneajaho
commented
Nov 17, 2024
libs/ngxtension/linked-query-param/src/linked-query-param.spec.ts
Outdated
Show resolved
Hide resolved
eneajaho
force-pushed
the
feat/linked-query-param-initial
branch
2 times, most recently
from
December 1, 2024 14:42
0a67319
to
097819a
Compare
eneajaho
changed the title
wip: feat(linked-query-param): add initial implementation for linked query…
feat: add linkedQueryParam implementation, tests and docs
Dec 1, 2024
eneajaho
force-pushed
the
feat/linked-query-param-initial
branch
from
December 1, 2024 14:45
097819a
to
fbba399
Compare
eneajaho
force-pushed
the
feat/linked-query-param-initial
branch
from
December 1, 2024 14:52
fbba399
to
1b251b6
Compare
JeanMeche
reviewed
Dec 1, 2024
apps/test-app/src/app/linked-query-param/linked-query-param-insideObject.component.ts
Outdated
Show resolved
Hide resolved
nartc
requested changes
Dec 2, 2024
apps/test-app/src/app/linked-query-param/linked-query-param-basic.component.ts
Outdated
Show resolved
Hide resolved
apps/test-app/src/app/linked-query-param/linked-query-param-basic.component.ts
Outdated
Show resolved
Hide resolved
apps/test-app/src/app/linked-query-param/linked-query-param-insideObject.component.ts
Show resolved
Hide resolved
eneajaho
force-pushed
the
feat/linked-query-param-initial
branch
from
December 2, 2024 18:45
1b251b6
to
265ebff
Compare
The `linkedQueryParam` utility function creates a signal that is linked to a query parameter in the URL. This allows you to easily keep your Angular application's state in sync with the URL, making it easier to share and bookmark specific views.
eneajaho
force-pushed
the
feat/linked-query-param-initial
branch
from
December 2, 2024 23:16
265ebff
to
5d93e68
Compare
nartc
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docs for most of the usecases:
Added example for filtering and pagination with resource API.
Added multiple tests to test all the possible usecases.
Added 2 helper functions for easier parsing (paramToNumber, paramToBoolean), with support for defaultValue.
Here is some self-explanatory code examples:
Playground: https://stackblitz.com/edit/stackblitz-starters-v1gtrd?file=src%2Ftodos.ts