Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): use proxy to get members from selector function #301

Merged
merged 2 commits into from
Jun 9, 2021
Merged

feat(core): use proxy to get members from selector function #301

merged 2 commits into from
Jun 9, 2021

Conversation

AliYusuf95
Copy link
Contributor

Solve #299

@AliYusuf95 AliYusuf95 marked this pull request as ready for review June 8, 2021 10:53
nartc
nartc reviewed Jun 9, 2021
View reviewed changes
Copy link
Owner

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great job man! This is such a good enhancement to the library. PR LGTM, just a couple of nitpicks!

packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
packages/core/src/lib/create-mapper/get-member-path.util.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AliYusuf95
Copy link
Contributor Author

@nartc thanks for reviewing the PR, all notes have been resolved.

nartc
nartc approved these changes Jun 9, 2021
View reviewed changes
Copy link
Owner

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@nartc nartc merged commit 704c6ad into nartc:main Jun 9, 2021
@nartc nartc mentioned this pull request Jun 9, 2021
Closed
@micalevisk micalevisk mentioned this pull request Jun 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartc nartc nartc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliYusuf95 @nartc